Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodical spelling corrections and other text fixes #952

Merged
merged 11 commits into from Apr 21, 2021

Conversation

SannitaSSJ
Copy link
Contributor

@SannitaSSJ SannitaSSJ commented Apr 21, 2021

Concepts_CIV4GameText.xml: removed French, Italian and Spanish translations from Entertainer entries (they were about Commerce, not entertainers, and their quality was really poor too)

Bonus_CIV4GameText.xml: adding pedia description for following bonuses: Crystal Glassware, Fake Gems, Ming Vases, Pegasus, Quetzalcoatl

plus the usual typo fixing and translation updating.

@SannitaSSJ SannitaSSJ added the text Text or localization label Apr 21, 2021
@SannitaSSJ SannitaSSJ self-assigned this Apr 21, 2021
@SannitaSSJ SannitaSSJ added this to In progress in Translations, SFX, and Text via automation Apr 21, 2021
@github-actions github-actions bot added the xml Related to the XML data label Apr 21, 2021
Entertainer concept had French, Italian and Spanish translations about Commerce (and their quality was really poor too)
Adding pedia description for following bonuses: Crystal Glassware, Fake Gems, Ming Vases, Pegasus, Quetzalcoatl
@flabbert flabbert marked this pull request as ready for review April 21, 2021 18:44
Copy link
Contributor

@flabbert flabbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@SannitaSSJ SannitaSSJ moved this from In progress to Review in Translations, SFX, and Text Apr 21, 2021
@SannitaSSJ SannitaSSJ merged commit 42539f5 into master Apr 21, 2021
Translations, SFX, and Text automation moved this from Review to Done Apr 21, 2021
@SannitaSSJ SannitaSSJ deleted the spelling-corrections branch April 21, 2021 18:57
@SannitaSSJ SannitaSSJ mentioned this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
text Text or localization xml Related to the XML data
Development

Successfully merging this pull request may close these issues.

None yet

3 participants