Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ESM node integration in separate renderer process #899

Closed
ThaUnknown opened this issue Feb 2, 2023 · 3 comments
Closed

feat: ESM node integration in separate renderer process #899

ThaUnknown opened this issue Feb 2, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ThaUnknown
Copy link

Is your feature request related to a problem? Please describe.
To run node integration inside electron, electron suggests not enabling node integration in any context that loads remote content. This means loading a worker or a new window with node integration enabled, workers however dont have webrtc, so this means it has to be a separate window. ESM support also becomes an issue.

Describe the solution you'd like
A 2nd renderer window, with node integration enabled.

Describe alternatives you've considered
uuuuuuuuuuh

@ThaUnknown ThaUnknown added the enhancement New feature or request label Feb 2, 2023
@cawa-93
Copy link
Owner

cawa-93 commented Feb 2, 2023

You should use node integration how it described in docs through preload script.

@cawa-93 cawa-93 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2023
@ThaUnknown
Copy link
Author

You should use node integration how it described in docs through preload script.

running node integration inside preload means you can't benefit from threading, and any resource intensive tasks will make the entire UI lag, it additionally can't run a lot of the node API's

@strogonoff
Copy link

@ThaUnknown what prevents you from spawning another window using Electron’s API? Just as long as you’re sure you aren’t inadvertently giving any way to load something remote in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants