Skip to content

Commit

Permalink
Merge pull request #133 from sergey-alekseev/patch-1
Browse files Browse the repository at this point in the history
Test against supported Rails 4.2
  • Loading branch information
straydogstudio committed Dec 16, 2019
2 parents 237cbbd + 5a3c519 commit dfaa57f
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .travis.yml
Expand Up @@ -9,6 +9,7 @@ notifications:
- noel@peden.biz
on_success: always
env:
- RAILS_VERSION=4.2
- RAILS_VERSION=5.0
- RAILS_VERSION=5.1
- RAILS_VERSION=5.2
Expand All @@ -18,7 +19,8 @@ rvm:
- 2.5
- 2.6
before_install:
- gem update bundler
- gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
- gem install bundler -v '< 2'
script:
spec/ci.rb
matrix:
Expand Down
6 changes: 5 additions & 1 deletion Gemfile
Expand Up @@ -11,18 +11,23 @@ case ENV['RAILS_VERSION']
when '6.0'
gem 'rails', "~> 6"
gem 'responders', '~> 3.0'
gem 'sqlite3'
when '5.2'
gem 'rails', "~> 5.2"
gem 'responders', '~> 3.0'
gem 'sqlite3'
when '5.1'
gem 'rails', "~> 5.1"
gem 'responders', '~> 3.0'
gem 'sqlite3'
when '5.0'
gem 'rails', "~> 5.0"
gem 'responders', '~> 2.0'
gem 'sqlite3'
when '4.2'
gem 'rails', "~> 4.2"
gem 'responders', '~> 2.0'
gem 'sqlite3', '1.3.13'
# when '4.1'
# gem 'rails', "~> 4.1.0"
# when '4.0'
Expand All @@ -37,7 +42,6 @@ gem 'sprockets', '~> 3.0'
# jquery-rails is used by the dummy application
gem "jquery-rails"
gem "thin"
gem "sqlite3", '~> 1.4', :platform => [:ruby, :mswin, :mingw]

# Declare any dependencies that are still in development here instead of in
# your gemspec. These might include edge Rails or gems from your path or
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -36,7 +36,7 @@ See [previous installations](#previous-installations) if needed.

## Requirements

* Rails 4.2, 5.x (tested), or 6.0 (tested)
* Tested on Rails 4.2, 5.x and 6.0
* For Rails 3.1 or 3.2 use version 3.0
* **As of 0.5.0 requires Axlsx 2.0.1, but strongly suggests 2.1.0.pre, which requires rubyzip 1.1.0**
* As of Rails 4.1 you must use `render_to_string` to render a mail attachment.
Expand Down
1 change: 0 additions & 1 deletion axlsx_rails.gemspec
Expand Up @@ -26,7 +26,6 @@ Gem::Specification.new do |s|
s.add_development_dependency "capybara"
s.add_development_dependency "roo"
s.add_development_dependency "rubyzip"
s.add_development_dependency "sqlite3", '~> 1.4'
s.add_development_dependency "growl"
s.add_development_dependency "rb-fsevent"
s.add_development_dependency "coveralls"
Expand Down
2 changes: 1 addition & 1 deletion spec/ci.rb
Expand Up @@ -8,7 +8,7 @@
exit system("cd spec/dummy_#{ENV['RAILS_VERSION']} && bundle install --without debug && rails db:reset && cd ../../ && bundle exec rspec spec")
elsif ENV['RAILS_VERSION'] =~ /^4/
puts "Testing Rails #{ENV['RAILS_VERSION'].to_i}"
exit system("cd spec/dummy_#{ENV['RAILS_VERSION'].to_i} && bundle install --without debug && bundle exec rake db:create && bundle exec rake db:migrate && cd ../../ && bundle exec rspec spec")
exit system("cd spec/dummy_#{ENV['RAILS_VERSION'].to_i} && bundle install --without debug && rake db:reset && cd ../../ && bundle exec rspec spec")
else
puts "Testing Rails 3"
exit system('cd spec/dummy && bundle install --without debug && bundle exec rake db:create && bundle exec rake db:migrate && cd ../../ && bundle exec rspec spec')
Expand Down

0 comments on commit dfaa57f

Please sign in to comment.