Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on PHP 7.3 #79

Closed
irkallacz opened this issue Jan 13, 2019 · 3 comments
Closed

Does not work on PHP 7.3 #79

irkallacz opened this issue Jan 13, 2019 · 3 comments

Comments

@irkallacz
Copy link
Contributor

I try to use it on PHP 7.3. and I got Warning: preg_match(): Compilation failed: invalid range in character class at offset 4

What I found that PHP 7.3. use PCRE2: http://php.net/manual/en/migration73.other-changes.php#migration73.other-changes.pcre witch cause problem in php simple html dom parser sunra/php-simple-html-dom-parser#64

First option is use different library like https://github.com/Kub-AT/php-simple-html-dom-parser

Second options is wait until sunra/php-simple-html-dom-parser have new version.

@jschroed91
Copy link
Member

I'd like to move away from the dependency at some point altogether - but switching to the other repository which has the latest updates of the original package seems like an OK solution for 7.3 support.

I'm not able to test switching the lib today, but will do that early this week - if someone opens a PR w/ the changes I'd take that as well :)

@matthewgoslett
Copy link

This is still a problem for me on latest version 0.1.9.

screenshot_1344

@SavageTiger
Copy link
Contributor

@matthewgoslett @irkallacz Do you have the same when you run functional tests on 7.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants