Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review #2

Open
ghost opened this issue Apr 13, 2023 · 0 comments
Open

review #2

ghost opened this issue Apr 13, 2023 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 13, 2023

main.tf

Line 16: data object should be in data.tf
Line 40: data object should be in data.tf

Line 53: Do we really need to allow secretsmanager:GetSecretValue for all secrets? I think we can scope that down to try to follow the least privilege principle.

variables.tf

Line 7: regarding name, I would suggest enforcing kebab-case throughout the module , or moving to snake_case, but if we leave this as is, we could end up with a name like cost_alert-lambda-role. What is your preference?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants