Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on CorrectAssemblyPath part documentation #2

Closed
curunoir opened this issue Mar 24, 2023 · 1 comment
Closed

Elaborate on CorrectAssemblyPath part documentation #2

curunoir opened this issue Mar 24, 2023 · 1 comment

Comments

@curunoir
Copy link

Hello and thanks for this package.

I would like to use it to upgrade an existing .net framework project and installer towards .net core.

The installer has custom actions with forms and stuff like service creation and it uses InstallContext class to get msi properties.
When I use your package to get these classes back I can't use a publish output in custom action installer as InstallerClass, otherwise I'm getting this error

ERROR: Unable to build custom action named 'Éléments de publication from xxx (Active)', InstallerClass property is only valid for assemblies.

As the CorrectAssemblyPath part of the documentation is not very clear to me I wonder if it is related and what ti do exactly if it is so I would appreciate some light. :)

Best regards

@cbenard
Copy link
Owner

cbenard commented Mar 28, 2023

I'm not sure without seeing your code. This was a short-term pre-requisite I needed and it's just a ported copy of Microsoft's code with the extra stuff I wrote for CorrectAssemblyPath() for .NET Core/5+.

You'll probably have to debug it yourself. Feel free to submit any PRs, but I won't be able to dedicate any time on this to debugging others code consuming it. If you find any errors in it though, please do submit a PR.

@cbenard cbenard closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants