Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for alternative output syntax in TestNG i.e. "expected […] but found […]" #92

Merged
merged 1 commit into from Aug 24, 2013

Conversation

JKrag
Copy link
Contributor

@JKrag JKrag commented Aug 23, 2013

Hi Cedric.
As we discussed, I have added support for the alternative TestNG output syntax, so this one now also can be parsed for side-by-side viewing.

I took the opportunity to rewrite the whole TestNG parsing method to use precompiled regex's instead of adding yet another "if" block. This should make it easier to add additional output formats in the future, and possibly allow you add support for configuring these locally? (properties file or preferences?).

I haven't had the option of retesting the syntax-forms that my own testNG doesn't provide, but I have done my utmost to match the regexes with the same strings as previous.

Hope it works out.

…but found […] ).

Rewrote TestNG parsing method to use regex's to make it easier to add additional output formats.
cbeust added a commit that referenced this pull request Aug 24, 2013
Added support for alternative output syntax in TestNG i.e. "expected […] but found […]"
@cbeust cbeust merged commit e867286 into testng-team:master Aug 24, 2013
@cbeust
Copy link
Collaborator

cbeust commented Aug 24, 2013

Thanks, Jan.

A minor thing: the way you initialize the static map is not thread safe, you usually want to synchronize around it (I don't think it's an issue in this case since it's unlikely the user will run two of these in parallel, but just FYI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants