Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize sending Channel messages in isolates #389

Merged
merged 2 commits into from Jul 6, 2022

Conversation

blaugold
Copy link
Member

@blaugold blaugold commented Jul 6, 2022

Fixes #355

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #389 (ea62fef) into main (2b96141) will increase coverage by 1.49%.
The diff coverage is 94.90%.

❗ Current head ea62fef differs from pull request most recent head 406ddbb. Consider uploading reports for the commit 406ddbb to get more accurate results

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   89.19%   90.69%   +1.49%     
==========================================
  Files         145      125      -20     
  Lines        9942     8918    -1024     
==========================================
- Hits         8868     8088     -780     
+ Misses       1074      830     -244     
Flag Coverage Δ
e2e.cbl 90.69% <94.90%> (+0.02%) ⬆️
unit.cbl ?
unit.cbl_dart ?
unit.cbl_generator ?
unit.cbl_sentry ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/lib/src/service/serialization/serialization.dart 86.23% <86.66%> (-0.54%) ⬇️
packages/cbl/lib/src/service/cbl_service_api.dart 97.95% <94.33%> (-0.55%) ⬇️
...ackages/cbl/lib/src/database/proxy_blob_store.dart 100.00% <100.00%> (ø)
packages/cbl/lib/src/service/cbl_service.dart 98.75% <100.00%> (+<0.01%) ⬆️
packages/cbl/lib/src/service/channel.dart 86.70% <100.00%> (+0.81%) ⬆️
...rc/service/serialization/isolate_packet_codec.dart 100.00% <100.00%> (ø)
packages/cbl/lib/src/typed_data/annotations.dart 22.22% <0.00%> (-77.78%) ⬇️
packages/cbl/lib/src/support/edition.dart 50.00% <0.00%> (-50.00%) ⬇️
packages/cbl/lib/src/support/streams.dart 72.51% <0.00%> (-22.91%) ⬇️
packages/cbl/lib/src/support/isolate.dart 66.66% <0.00%> (-8.34%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b96141...406ddbb. Read the comment docs.

@blaugold blaugold merged commit e1ef25c into main Jul 6, 2022
@blaugold blaugold deleted the blaugold/issue355 branch July 6, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove need for serialization when sending messages through ReceivePort Channel
1 participant