Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add locking for a number of finalizers #412

Merged
merged 2 commits into from Sep 5, 2022
Merged

Conversation

blaugold
Copy link
Member

@blaugold blaugold commented Sep 5, 2022

Fixes #407

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #412 (1b1c3b9) into main (f58fa34) will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   74.65%   74.67%   +0.02%     
==========================================
  Files         144      144              
  Lines       12608    12613       +5     
==========================================
+ Hits         9412     9419       +7     
+ Misses       3196     3194       -2     
Flag Coverage Δ
e2e.cbl 89.09% <100.00%> (+0.01%) ⬆️
unit.cbl 2.85% <0.00%> (-0.01%) ⬇️
unit.cbl_dart 16.04% <0.00%> (ø)
unit.cbl_generator 31.62% <0.00%> (-0.03%) ⬇️
unit.cbl_sentry 9.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cbl_ffi/lib/src/replicator.dart 62.81% <50.00%> (-2.13%) ⬇️
...ckages/cbl/lib/src/replication/ffi_replicator.dart 59.11% <87.50%> (+1.75%) ⬆️
packages/cbl/lib/src/query/ffi_query.dart 59.68% <100.00%> (+2.09%) ⬆️
packages/cbl_ffi/lib/src/query.dart 84.74% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blaugold blaugold merged commit 55bc3a5 into main Sep 5, 2022
@blaugold blaugold deleted the blaugold/issue407 branch September 5, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that finalizers do not run concurrently with isolate
1 participant