New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insure left and right division is working properly with mldivide.m and mrdivide.m #1118
Comments
According to SMT documentation, I think this will cause inconsistency in the future and we should define |
Try it, see if tests pass! Certainly sounds like less code to maintain going forward. |
Use "mldivide" instead of running sympy code directly. Closes gnu-octave#1118. * inst/@sym/mrdivide.m: Simplify it. * inst/@sym/mldivide.m: Adjust accordingly to avoid infinite loop.
Use @sym/mldivide instead of running sympy code directly. Closes gnu-octave#1118. * inst/@sym/mrdivide.m: Simplify it. * inst/@sym/mldivide.m: Adjust accordingly to avoid infinite loop.
Use @sym/mldivide instead of running sympy code directly. Closes gnu-octave#1118. * inst/@sym/mrdivide.m: Simplify it. * inst/@sym/mldivide.m: Adjust accordingly to avoid infinite loop.
Due to some failing tests we noticed that
A = C/B
whereC
was generated byA*B=C
was failing inmrdivide.m
. The issue is issue #1079. In an attempt to fix this issue made two minor changes tomrdivide.m
. One was the a call to regular division if B is a scalar, or more accurately isn't a matrix, the other was solve call, from upstream in the case where B is a matrix. No changes were needed for to fixmldivide.m
.Experimentation showed that this will fail if
B
is not invertable.Should we add an expected failure or documentation to outline what won't work with these operators?
The text was updated successfully, but these errors were encountered: