Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sym/ztrans references non-implemented function #1122

Closed
cbm755 opened this issue May 5, 2022 · 2 comments · Fixed by #1167
Closed

sym/ztrans references non-implemented function #1122

cbm755 opened this issue May 5, 2022 · 2 comments · Fixed by #1167
Assignees
@alexvong243f
Milestone
3.0.0

Comments

@cbm755
Copy link
Collaborator

cbm755 commented May 5, 2022

For 3.0.0, we could either comment out the @seealso line.

Of course it should be added back if iztrans is added.
@cbm755 cbm755 added this to the 3.0.0 milestone May 5, 2022
@cbm755
Copy link
Collaborator Author

cbm755 commented Jul 1, 2022 •
edited by alexvong243f

@alexvong243f shall we just comment out the @seealso for 3.0.0?

@alexvong243f
Copy link
Collaborator

Yes, I think we can add iztrans later.

I (mostly) have an implementation of iztrans, but I'm not sure if I handle the case where it's not possible to find the inverse transform correctly. Currently, it returns an unevaluated limit of an unevaluated integral (using the definition of course, but there're multiple ways to rewrite the definition into something sympy can represent...) when the inverse transform cannot be found.

alexvong243f pushed a commit to alexvong243f/octsympy that referenced this issue Jul 2, 2022
@sym/ztrans: Temporarily remove reference to unimplemented function.
cdcd209 
We will add it back after we implement @sym/iztrans.

Closes gnu-octave#1122.

* inst/@sym/ztrans.m: Remove reference.
@alexvong243f alexvong243f mentioned this issue Jul 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexvong243f alexvong243f

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

@sym/ztrans: Temporarily remove reference to unimplemented function. alexvong243f/octsympy
2 participants
@cbm755 @alexvong243f