Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Catch issues similar to #1060 #1141

Open
alexvong243f opened this issue Jun 21, 2022 · 1 comment
Open

CI: Catch issues similar to #1060 #1141

alexvong243f opened this issue Jun 21, 2022 · 1 comment

Comments

@alexvong243f
Copy link
Collaborator

alexvong243f commented Jun 21, 2022

I suggest we should make the source directory read-only in CI, in order to catch issues similar to #1060. What do people think?

The above idea doesn't work. When we run the CI tests, the current directory is actually the home directory, not the source directory. We need to modify the CI in another way.

@alexvong243f alexvong243f changed the title CI: Make source directory read-only to catch issues similar to #1060 CI: Catch issues similar to #1060 Jun 21, 2022
@cbm755
Copy link
Collaborator

cbm755 commented Jun 21, 2022

Agree this could be useful.

But I like the idea that most of our Makefile is very similar to other packages. In the past we did some effort to make it largely boilerplate. Changes that would benefit other projects seem useful... There might be lower hanging fruit like #1142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants