close and reset Python subprocess state on clear #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move popen2 reset logic to a new helper function, and call it using a persistent onCleanup object. Fixes gnu-octave#1015.
mtmiller
commented
Apr 1, 2020
| t = fclose(fout); fout = []; | ||
| A = A && (t == 0); | ||
| end | ||
| cleanup = []; |
There was a problem hiding this comment.
This assignment triggers a call to the new reset helper function
| fin = []; | ||
| fout = []; | ||
| pid = []; | ||
| A = true; |
There was a problem hiding this comment.
Unfortunately I can't figure out a way to both use onCleanup and capture the return value
| %% @var{A} is the resulting object, which might be an error code. | ||
| %% @end deftypefun | ||
|
|
||
| function A = python_ipc_popen2_reset (fin, fout, pid) |
There was a problem hiding this comment.
Maybe no point in returning any status here now?
There was a problem hiding this comment.
I think I agree. I'm merging this to a local branch so I can try it on CI as well as try removing these return vlaues.
mtmiller
commented
Apr 1, 2020
| @@ -0,0 +1,51 @@ | |||
| %% Copyright (C) 2020 Mike Miller | |||
There was a problem hiding this comment.
This file was copied from python_ipc_popen2.m, do you think me should propagate the original Copyright here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move popen2 reset logic to a new helper function, and call it using a
persistent onCleanup object.
Fixes #1015.