Fixes #1067 #1136
Merged
Fixes #1067 #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 17, 2022 17:43
Partly Fixes gnu-octave#1067. * .github/workflows/main.yml: Add new job "bist-pythonic" and "doctests-pythonic". * .travis.yml: Remove it.
Previously, "pycall_sympy__ ('return _ins[0]', [])" evaluates to
--8<---------------cut here---------------start------------->8---
ans = [Python object of type array.array]
array('d')
--8<---------------cut here---------------end--------------->8---
when using the pythonic interface, causing @sym/subsasgn test
failures.
Partly fixes gnu-octave#1067.
* inst/private/store_vars_in_python.m: Update it.
* inst/pycall_sympy__.m: Add test accordingly.
Follow-up of 4f88cde. Without this import, some tests using the pythonic interface will fail with the error "NameError: name 'Str' is not defined". Partly fixes gnu-octave#1067. * inst/private/python_ipc_native.m: Fix it.
cbm755
reviewed
Jun 18, 2022
| # --8<---------------cut here---------------end--------------->8--- | ||
| # by replacing all occurences of | ||
| # "py.collections.Callable" to "py.collections.abc.Callable" and | ||
| # "py.collections.Sequence" to "py.collections.abc.Sequence" |
There was a problem hiding this comment.
I guess we need some new issue to fix this properly rather than sed'ing around it.
|
This looks good to me! |
|
------- Original Message -------
On Saturday, June 18th, 2022 at 4:04 PM, Colin B. Macdonald ***@***.***> wrote:
@cbm755 commented on this pull request.
In .github/workflows/main.yml:
> + sudo git config --global --add safe.directory /home/jovyan/octsympy
+ docker exec oc apt-get update
+ docker exec oc apt-get install -y libpython3-dev
+ docker exec oc pip3 install packaging
+ docker exec oc pip3 install sympy=="$SYMPY"
+ docker exec oc octave-cli --eval "pwd; ls"
+ docker exec oc octave-cli --eval "pkg install -forge doctest"
+ docker exec oc \
+ git clone https://gitlab.com/mtmiller/octave-pythonic.git
+ # FIXME: Workaround the following error
+ # --8<---------------cut here---------------start------------->8---
+ # error: subsref: cannot index Python object, not sequence or callable
+ # --8<---------------cut here---------------end--------------->8---
+ # by replacing all occurences of
+ # "py.collections.Callable" to "py.collections.abc.Callable" and
+ # "py.collections.Sequence" to "py.collections.abc.Sequence"
I guess we need some new issue to fix this properly rather than sed'ing around it.
Yeah the sed trick is more a hack than a proper fix.
@chrisjohgorman mentioned in #1067 (comment) that he had a fix waiting to be merged to upstream pythonic. Maybe this is what we want.
… —
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
alexvong243f
commented
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1067 by enabling pythonic tests in CI, removing
.travis.ymland fixing all test failures.