Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disp for compatibility with Octave 4.1+ #264

Merged
merged 1 commit into from Sep 21, 2015

Conversation

mtmiller
Copy link
Collaborator

Fixes #263.

@cbm755
Copy link
Collaborator

cbm755 commented Sep 21, 2015

ok thanks for this, I will merge.

But AFAICT from online documentation get(0,'FormatSpacing') is still how its done in Matlab, so this will need a further patch for Symbolic to keep working under matlab.

cbm755 added a commit that referenced this pull request Sep 21, 2015
Fix disp for compatibility with Octave 4.1+
@cbm755 cbm755 merged commit 8860697 into gnu-octave:master Sep 21, 2015
@cbm755 cbm755 mentioned this pull request Sep 21, 2015
@mtmiller
Copy link
Collaborator Author

Hmm, I didn't realize this is a Matlab compatibility thing, let's see if we get this property added again in Octave.

@cbm755
Copy link
Collaborator

cbm755 commented Sep 23, 2015

We'll I'm not completely sure: the source code you linked seemed suggests its deprecated in Matlab... See code comments here. But I cannot find confirmation of that anywhere...

cbm755 added a commit that referenced this pull request Sep 23, 2015
Bit of cleanup on top of #264 so that Matlab still works.  Need to
hide `__` inside eval.
@cbm755
Copy link
Collaborator

cbm755 commented Sep 23, 2015

FTR, could revert this and ee0649d if Octave adds the get(0,...) approach again.

@mtmiller mtmiller deleted the compactformat branch March 10, 2016 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants