Fix text search #39
Merged
Fix text search #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 10 10
Lines 523 523
=======================================
Hits 473 473
Misses 50 50 |
cbouy
force-pushed
the
fix-text-search
branch
from
a395307
to
c447a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.
Text searches containing any of the following regex characters
-[]{}()*+?.,\^$|#would automatically return an empty grid, preventing searching for CAS numbers and any other identifier or text containing the above characters.This has been temporarily patched until a proper fix is released in the underlying
list.jslibrary.