Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #5

Closed
elfring opened this issue Aug 1, 2016 · 4 comments
Closed

reserved identifier violation #5

elfring opened this issue Aug 1, 2016 · 4 comments

Comments

@elfring
Copy link

elfring commented Aug 1, 2016

I would like to point out that identifiers like "_DatabaseSearch" and "_FsearchApplication" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

@cboxdoerfer
Copy link
Owner

Yeah, probably a bad habit of mine. I will think of a better way how to do it.

@cboxdoerfer
Copy link
Owner

This is fixed in some parts now, but when declaring GObjects with G_DECLARE_FINAL_TYPE it can't be avoided.

@elfring
Copy link
Author

elfring commented Jul 19, 2021

🤔 How do you think about to influence the software evolution any more for affected identifiers?

@cboxdoerfer
Copy link
Owner

Like I said, in the case of GObject declarations it's what macros like G_DECLARE_FINE_TYPE demand:

the MyAppWindow types is defined as a typedef of struct _MyAppWindow. The struct itself is not defined and should be defined from the .c file before G_DEFINE_TYPE() is used.

So I'm not going to change those identifiers. It's not feasible for me to take a stand against glib's API design and code conventions. All other identifiers should now adhere to the C coding standards.

@The-Maize The-Maize mentioned this issue Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants