Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labelheight changes if label goes into scrolling state #79

Closed
AvdLee opened this issue Oct 20, 2014 · 6 comments
Closed

Labelheight changes if label goes into scrolling state #79

AvdLee opened this issue Oct 20, 2014 · 6 comments

Comments

@AvdLee
Copy link

AvdLee commented Oct 20, 2014

If the containing text is long enough to trigger scrolling, the frame of the label is different then a label where scrolling isn't needed.

As I'm not using autolayout for my label, the frame's position gets wrong.

This happens after the 2.0.7 update.

@cbpowell
Copy link
Owner

Is this only an issue for non-autolayout placed views? The demo labels seem to do OK with short strings. Also do you mean the frame of the subLabel, or the MarqueeLabel itself?

@AvdLee
Copy link
Author

AvdLee commented Oct 21, 2014

The same problem exists with autolayout, just tried out to see. The frame of the label is explicit different for short strings.

See these images:
ios simulator screen shot 21 oct 2014 08 56 55
ios simulator screen shot 21 oct 2014 08 57 00

@cbpowell
Copy link
Owner

Whoops, I see what's causing it. I accidentally/stupidly removed a line of code in 2.0.7 which set the height of the sublabel to the height of the MarqueeLabel.

I've pushed a commit to fix it, but I can't bump the version and push a release until later today. If you want to try it out you can pull right from the repository rather than Cocoapods.

@cbpowell
Copy link
Owner

Hopefully fixed in release v2.0.8 - if not, let me know. The mistake v2.0.8 fixes was certainly one problem, at least.

@AvdLee
Copy link
Author

AvdLee commented Oct 22, 2014

You've made my day! Working like a charm 👍 :)

@cbpowell
Copy link
Owner

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants