-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting case-insensitive for Box's API response headers #99
Comments
Hi @kiseyob , thanks for reaching out. I have just been made aware of this change, but thankfully it should be pretty simple to resolve. I will put it on my to-do list and try to get a release out. If you wanted to work on PR though, that would be greatly appreciated! |
Thank you for your quick reply. I'm looking forward it could be done before May. |
Hey @kiseyob , update for you! After some investigation, it seems like no change is needed and that Boxr will continue to work as expected after the header update from Box. If you look at the source for Httpclient which we use for HTTP requests, you will notice that header lookups are case-insensitive already. I verified this by debugging some calls to the
Thankfully most HTTP libraries already adhere to the HTTP spec that headers are not case-sensitive, so there is nothing to be done by users of this library. Thanks for the report! |
Indeed, httpclient handle with |
Hello,
I got the below email from Box.
When I check the code in boxr, there are couple places like
header['WWW-Authenticate']
,header['Location']
,header['Retry-After']
,headers['If-Match']
,headers["Content-Type"]
.Do you have a plan to deal this soon?
The text was updated successfully, but these errors were encountered: