Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The converted file is very slow after dragging the progress bar #10

Closed
5UFKEFU opened this issue May 13, 2024 · 47 comments
Closed

The converted file is very slow after dragging the progress bar #10

5UFKEFU opened this issue May 13, 2024 · 47 comments

Comments

@5UFKEFU
Copy link

5UFKEFU commented May 13, 2024

Using the following command, you can see that the keyframes are very regularly spaced every 33 frames.
ffprobe -select_streams v:0 -show_frames -show_entries frame=pict_type -of csv input.mov | grep -n 'I' | cut -d ':' -f 1

1
33
65
97
129
161
193
225
257
289
321
353
385
417
449
481
513
545
577
609
641
673
705
737
769
801
833
865
897
929
961
993
1025

follow command show:moov before mdat.

mp4box -info MARVELS\ IRON\ MAN\ 3\ -\ BLU-RAY\ 3D_AVP.mov

[iso file] Unknown box type vexu in parent hvc1
[iso file] Unknown box type hfov in parent hvc1
# Movie Info - 4 tracks - TimeScale 2400
Duration 02:22:23.223
Fragmented: no
Progressive (moov before mdat)
Major Brand qt   - version 512 - compatible brands: qt  
Created: GMT Sun May 12 06:36:25 2024


Chapter Track:
	#1 - 00:00:00.000 - "Chapter 01"
	#2 - 00:04:52.751 - "Chapter 02"
	#3 - 00:07:55.433 - "Chapter 03"
	#4 - 00:12:12.440 - "Chapter 04"
	#5 - 00:19:04.101 - "Chapter 05"
	#6 - 00:23:47.885 - "Chapter 06"
	#7 - 00:29:47.703 - "Chapter 07"
	#8 - 00:39:46.384 - "Chapter 08"
	#9 - 00:45:56.045 - "Chapter 09"
	#10 - 00:59:19.639 - "Chapter 10"
	#11 - 01:01:56.922 - "Chapter 11"
	#12 - 01:09:24.452 - "Chapter 12"
	#13 - 01:18:41.508 - "Chapter 13"
	#14 - 01:23:52.945 - "Chapter 14"
	#15 - 01:37:55.995 - "Chapter 15"
	#16 - 01:56:18.305 - "Chapter 16"
	#17 - 01:59:38.755 - "Chapter 17"

Meta-Data Tags:
	tool: GPAC-2.4-revrelease

# Track 1 Info - ID 1 - TimeScale 2400
Media Duration 02:10:32.875 
Track has 1 edits: track duration is 02:10:32.875
Track composition offset shift (negative CTS offset): 204
Track flags: Enabled In Movie In Preview Size is AspectRatio
Media Samples: 187801
Visual Track layout: x=0 y=0 width=1920 height=1080
Media Type: vide:hvc1
	Visual Sample Entry Info: width=1920 height=1080 (depth=24 bits)
	HEVC Video - Visual Size 1920 x 1080
	HEVC Info: Profile Main 10 @ Level 4 - Chroma Format YUV 4:2:0

	NAL Unit length bits: 32 - general profile compatibility 0x20000000

	Parameter Sets: 1 VPS 1 SPS 1 PPS 
	SPS resolution 1920x1080
	Bit Depth luma 10 - Chroma 10 - 1 temporal layers
	VPS#1 hash: 154C6C8AD2550609B8F1C387A91B029379047CAF
	SPS#1 hash: D5CD901536EBD730807D2B3C2C50D7D91BFEB632
	PPS#1 hash: 427C9C7AD14AF37E8DF4541BD1A8D479206059FA

	LHVC Info:
	NAL Unit length bits: 32
	Parameter Sets: 1 SPS 1 PPS 
	SPS resolution 1920x1088
	1 temporal layers
	HEVC base layer - Complete representation 0
	SPS#1 hash: 04EC58406BBECB8578349603A7DE68F9AF5577ED
	PPS#1 hash: 95AFDAAA3E19AE86B301A4664274E57B53149B5B
	RFC6381 Codec Parameters: hvc1.2.4.L120.B0
	Only one sync sample
	Max sample duration: 104 / 2400

# Track 2 Info - ID 2 - TimeScale 48000
Media Duration 02:10:32.874 
Track has 1 edits: track duration is 02:10:32.875
Track flags: Enabled In Movie
Media Samples: 375977984 - CFR 48000/sec
1 UDTA types: 
	name: Surround 7.1
Alternate Group ID 1
Media Type: soun:in24
	PCM Audio Sample Rate 48000 8 channel(s) 24-bits little-endian
	RFC6381 Codec Parameters: in24
	All samples are sync
	Max sample duration: 1 / 48000

# Track 3 Info - ID 3 - TimeScale 1000
Media Duration 02:10:32.867 
Track has 1 edits: track duration is 02:10:32.866
Track flags: Disabled In Movie
Media Samples: 17
Media Type: text:text
	QT/3GPP text
	Size 0 x 0 - Translation X=0 Y=0 - Layer 0
	RFC6381 Codec Parameters: text
	All samples are sync
	Max sample duration: 1102310 / 1000

# Track 4 Info - ID 4 - TimeScale 90000
Media Duration 02:22:23.223 
Track flags: Enabled In Movie In Preview
Media Samples: 2171
Media Type: subp:mp4s
	RFC6381 Codec Parameters: mp4s.E0
	All samples are sync
	Max sample duration: 67107840 / 90000

@cbusillo
Copy link
Owner

Do you have a suggestion on how to improve this? I hadn't noticed bad performance when dragging the bar, but I also wasn't paying attention.

@mikemonello
Copy link

I have been having this issue on quite a few rips with no solution. If I try to skip to a later part of the movie it just hangs forever. Sometimes it will play audio with a black video screen.

@cbusillo
Copy link
Owner

Its it reproducible on all videos or just some

@5UFKEFU
Copy link
Author

5UFKEFU commented May 14, 2024

I tried using:spatial instead of spatial-media-kit-tool and MP4box and found a good performance improvement.
https://blog.mikeswanson.com/spatial_docs/#make

@cbusillo
Copy link
Owner

Mike reached out to me at one point. Let me talk to him and see what he says. Thank you for the suggestion!

@cbusillo
Copy link
Owner

So I sat down on my Mac and tried scrolling through a few videos and they all scroll instantly. Even with a 90GB video over wifi. Is there a specific way this issue is triggered or specific videos or maybe it only happens on the AVP? I'm trying to reproduce it so I can make sure its fixed.

@cbusillo
Copy link
Owner

Quick update. I made the changes and need to test now. This is always the longest part. lol. I'll post an update later if its works and I push the code live. I'm not sure if Mike's needs cdist to work and not sure how to deal with that value if so.

@mikemonello
Copy link

mikemonello commented May 14, 2024

The issue appears on my laptop (Apple M1 Max, Sonoma 14.4.1) and my AVP. Here's a video of what it does on the desktop. It acts the same exact way on my AVP. https://www.dropbox.com/scl/fi/syhwrgxg703qkr4hk0hzp/CleanShot-2024-05-14-at-10.46.26.mp4?rlkey=nd2ftmainjxrext666p3rjr3q&dl=0

As a test, I ripped an FSBS version from Blu-Ray, then converted it to Spatial via MVConverter (https://mvconverter.app), and that file does not have this issue. Here is on the same laptop: https://www.dropbox.com/scl/fi/jqpbspyhlr7pd0e275ych/CleanShot-MVConverterOutput.mp4?rlkey=4ktjezwfl75bo64fp1yco4jlx&dl=0

@cbusillo
Copy link
Owner

Everything works perfect on my machine! lol.

Since I am unable to reproduce the problem, I cannot verify Spatial will fix the problem. After I verify an encode works, I will push the changes and you can test for me.

Thank you for all the great feedback. Hopefully we can get this fixed for you. That issue looks really annoying.

@cbusillo
Copy link
Owner

My first try resulted in a square video that looked like it was taken on the AVP. I'll have to try again.

@cbusillo
Copy link
Owner

What parameter are you using to create spatial movies with spatial from Mike Swanson?

@cbusillo
Copy link
Owner

spatial is outputting 1:1 aspect video on my testing file. Waiting on the dev to see if it's a bug on his end. He apparently just added a feature that may be causing an issue.

@cbusillo
Copy link
Owner

After fixing the aspect ratio issue, My videos using the spatial tool is very slow to seek through video, has the fuzzy border of AVP videos, and cannot be used in an immersive environment. I'll have to see if I can figure out what is going on with all of that when I have time. It's really weird that the original MV-HEVC conversion tool works perfectly for some, but not everyone. One person had an issue that was solved by changing to software encoding. Of course that takes 10 times longer to encode.

@cbusillo
Copy link
Owner

I am adding a --software-encoder option you can test out. It takes a lot longer, but it's worth a try to see if that helps. That can help confirm where the issue is. I have had at least one person confirm their system has an issue with the hardware encoder.

@5UFKEFU
Copy link
Author

5UFKEFU commented May 23, 2024

I'm encountering a weirder problem now. Some of the videos I made are very normal, but some of them can be played directly on Mac using spaces. Dragging is also normal, but when I put this video on AVP, it Unable to play.
These are all the videos I made. You can use ORG to download the AVP videos you made.
https://www.febbox.com/share/z97aHTQZ

Currently normal ones include: Painted Skin 2 3D AVP,...

Abnormal ones include: Transformers The Last Kninght, 300 Rise of an Empire,..

截屏2024-05-24 01 25 49

@5UFKEFU
Copy link
Author

5UFKEFU commented May 24, 2024

I seem to have found the reason. I found that AVP does not support aac 5.1, but it does support aac stereo.
It is also multi-audio, and AVP supports ac3 5.1.
After I re-converted the audio of the same file, it can support playback.

@cbusillo
Copy link
Owner

I seem to have found the reason. I found that AVP does not support aac 5.1, but it does support aac stereo. It is also multi-audio, and AVP supports ac3 5.1. After I re-converted the audio of the same file, it can support playback.

Does this mean --transcode-audio fixes the issue?

@mikemonello
Copy link

No. I just tried to rip an ISO of Godzilla using --transcode-audio and the output won't scroll or play properly.

@5UFKEFU
Copy link
Author

5UFKEFU commented May 24, 2024

I seem to have found the reason. I found that AVP does not support aac 5.1, but it does support aac stereo. It is also multi-audio, and AVP supports ac3 5.1. After I re-converted the audio of the same file, it can support playback.

Does this mean --transcode-audio fixes the issue?
NO

@Samckatz
Copy link

I can also confirm that --transcode-audio does not solve the problem.
On a side note, does subtitles show up correctly on AVP encodes?

@cbusillo
Copy link
Owner

I don't currently have any images or discs to test with. I'll see if I can get something... It looks like subs are not getting inserted. I must have missed something there. At worst I can leave the exported subs in the folder with the output vide. I'll take a look when I have time.

As far as the title issue, I am very confused since I don't seem to have those issues. I am waiting on a clean ISO from Sam so I can try encoding and see if I get different results. So far everything I have encoded plays back perfect on Mac and AVP. You can see an example below. If anyone has suggestions, I am open.

Untitled2.mov

@cbusillo
Copy link
Owner

I think the issues may have been coming from mp4box. I'm still not sure why it was working for me. Either way, I am using the spatial tool now for the conversion and the muxing. Testing now. Spatial doesn't handle subs, so I am just copying the sub file with the video. I'll hopefully update tomorrow with a new release. Thank you everyone for the help.

@cbusillo
Copy link
Owner

I just pushed a new update that uses spatial instead of mp4box to mux the video and audio. I had to leave the subs out since spatial doesn't support them, but since they weren't working correctly anyway, I guess no loss.

I included the idx file for the subs in the output folder. I am open to suggestions on how to do the subs better. If @5UFKEFU @mikemonello and @Samckatz can test, I would really appreciate it before I make a reddit post to let people know. Thank you!! BTW, I did not use spatial for the MV-HEVC itself. It seems to generate a file that plays weird. It plays like the videos taken on the AVP. I'm open to input on that as well.

@mikemonello
Copy link

I'm out of town for the long weekend and don't have my drives with me, so I can't test until Monday night. I doubt I'd be able to get a complete iso file downloaded on this hotel wifi, hahaha

@cbusillo
Copy link
Owner

No rush @mikemonello, just give me a pass/fail when you get a chance. I'm hoping it's better for you all. I'll give up on subs for now and just include the file. I think there are third party players that will work with it. I tried it with Apple's but I don't think it likes the external sub file. The Spatial tool doesn't work with subs at all and after the issues with MP4Box, I don't want to use it again.

I'm thinking there was an update to MP4Box that messed with the mux. I don't think I'll have time to confirm that though. It takes so long to process then test.

@Samckatz
Copy link

I am encoding now and will report back my findings

@Samckatz
Copy link

I can confirm that the issue is resolved and it plays and scrolls flawlessly. Thank you @cbusillo

@ddevler
Copy link

ddevler commented May 26, 2024

There is an issue if the disc has subtitles. Seems you delete the folder then try to access a deleted file.

Running Rip disc to MKV file. -

Detecting crop parameters...
Getting subtitle tracks from /Volumes/data02/3D/complete/Spiders/Spiders_t00.mkv
Running ffmpeg to extract video, audio, and subtitles from MKV
Running Extract subtitle track from MKV |

Running FRIM to split MVC to stereo. \

Running Combine stereo HEVC streams to MV-HEVC. /

Running Remux audio and video to final output. /

Removed existing directory: /Volumes/data02/3D/complete/Spiders
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/user/Development/oss/BD_to_AVP/bd_to_avp/main.py", line 756, in main
    process_each(input_args)
  File "/Users/user/Development/oss/BD_to_AVP/bd_to_avp/main.py", line 818, in process_each
    move_file_to_output_root_folder(subtitle_output_path, input_args)
  File "/Users/user/Development/oss/BD_to_AVP/bd_to_avp/main.py", line 865, in move_file_to_output_root_folder
    muxed_output_path.replace(final_path)
  File "/opt/homebrew/Cellar/python@3.12/3.12.3/Frameworks/Python.framework/Versions/3.12/lib/python3.12/pathlib.py", line 1376, in replace
    os.replace(self, target)
FileNotFoundError: [Errno 2] No such file or directory: '/Volumes/data02/3D/complete/Spiders/Spiders_AVP.idx' -> '/Volumes/data02/3D/complete/Spiders_AVP.idx'

@cbusillo
Copy link
Owner

@ddevler my mistake, if you update that should already be fixed. Also I am doing a test run of working subs. mov does not support image based subs like the Blu-ray comes with. I found a way to rip and OCR them to convert them to a format mov likes.

If I am lucky, I should be able to update with a working subtitle included in the output file tomorrow.

@ddevler
Copy link

ddevler commented May 26, 2024

PGS subs can be a bit tricky. I don't think that will be easy to automate. Usually you have train the OCR based on the font used. Then still requires a bit of cleanup after the OCR is complete. Normally I don't mess with that unless there are forced subtitles that affect the movie.

@cbusillo
Copy link
Owner

I agree!! I found a Python library using tesseract that converts the PGS sup to srt. We shall see how bad it is. My thinking here is I would rather include them than ignore them if possible. If you have any experience or ideas, I am always interested @ddevler.

@cbusillo
Copy link
Owner

I thought I had a working solution converting them to sub/idx, but I guess that doesn't work with mov containers. Video is so frustrating.

@ddevler
Copy link

ddevler commented May 26, 2024

you need MPEG-4 Timed Text format (Tx3g) for mp4 or mov.

Personally I would just have an option to rip the subtitle track to file if the user wants it. Then they can deal with process of conversion and remux themselves.

@ddevler
Copy link

ddevler commented May 26, 2024

I think mp4box will allow you to convert the sub file and mux it.

sample commands

@cbusillo
Copy link
Owner

MP4Box was causing the seeking issue. I'm not sure why. The seeking issue went away when I used spatial to mux the final file, but it doesn't support subs.

@cbusillo
Copy link
Owner

Supposedly working version is pushed up now. I am doing testing on a blank machine to make sure I didn't mess up any paths or anything. I installed MP4Box 2.2.1 instead of MP4Box 2.4.0, that fixes the seeking issue. I also figured out what tags were missing from the subs to get them to work. It turns out QuickTime needs extra things compared to other players for the subs to work... I'll update everyone after I finish testing. You are welcome to run the install/update script now and see what happens, but I am famous for last minute path typos. lol

@cbusillo
Copy link
Owner

IMG_0069

@ddevler
Copy link

ddevler commented May 27, 2024

I'll give it a try.

Would it be possible to add an option "--only-forced-subs"? So it only includes them if there is forced subs that are necessary for dialog.

Maybe that is why I didn't notice the scrubbing issue. I've been using an older version of mp4box.

@cbusillo
Copy link
Owner

@ddevler, by default only forced subs should show up. If you notice in the background of my image, I have subtitles turned on in the accessibility settings.

Same on the older MP4Box. My install script uses version 2.2.1 explicitly and points to the binary in the /Applications folder. I tested the 2.5 nightly of MP4Box and it has the same issue. I spent time trying to figure out what caused the issue, but gave up.

@cbusillo
Copy link
Owner

I'm still waiting on my extra testing machine to finish an encode to say problem solved and ready for testing. Its a base model 16" M1 Pro, so it may take a while.

@ddevler
Copy link

ddevler commented May 27, 2024

I meant during encoding. Basically only include the subtitle track during processing if it's a forced subtitle track.

@ddevler
Copy link

ddevler commented May 28, 2024

didn't work for me. I tried with The Wolverine as ISO file which contains a forced subtitle track.

I have a The Wolverine_subtitles.sup file but not .srt. I'm guessing something failed with the conversion.
There are 3 files left: audio, video and sup file. If you want me to do any testing with commands.

Running Get disc and MVC video properties \

Custom MakeMKV profile created at /Volumes/data02/3D/complete/The Wolverine/custom_profile.mmcp.xml
Running Rip disc to MKV file. -

Detecting crop parameters...
Getting subtitle tracks from /Volumes/data02/3D/complete/The Wolverine/The Wolverine_t00.mkv
Running ffmpeg to extract video, audio, and subtitles from MKV
Converting /Volumes/data02/3D/complete/The Wolverine/The Wolverine_subtitles.sup to SRT
Running FRIM to split MVC to stereo. -

Running Combine stereo HEVC streams to MV-HEVC. /

Running Mux video, audio, and subtitles. \Error running command: Mux video, audio, and subtitles.
[iso file] Unknown box type vexu in parent hvc1

[iso file] Unknown box type hfov in parent hvc1

[iso file] Unknown box type vexu in parent hvc1

[iso file] Unknown box type hfov in parent hvc1

IsoMedia import The Wolverine_MV-HEVC.mov - track ID 1 - Video (size 1856 x 784)

Importing ISO File: |                    | (00/100)

Importing ISO File: |                    | (01/100)

Importing ISO File: |                    | (02/100)

Importing ISO File: |                    | (03/100)

Importing ISO File: |                    | (04/100)

Importing ISO File: |=                   | (05/100)

Importing ISO File: |=                   | (06/100)

Importing ISO File: |=                   | (07/100)

Importing ISO File: |=                   | (08/100)

Importing ISO File: |=                   | (09/100)

Importing ISO File: |==                  | (10/100)

Importing ISO File: |==                  | (11/100)

Importing ISO File: |==                  | (12/100)

Importing ISO File: |==                  | (13/100)

Importing ISO File: |==                  | (14/100)

Importing ISO File: |===                 | (15/100)

Importing ISO File: |===                 | (16/100)

Importing ISO File: |===                 | (17/100)

Importing ISO File: |===                 | (18/100)

Importing ISO File: |===                 | (19/100)

Importing ISO File: |====                | (20/100)

Importing ISO File: |====                | (21/100)

Importing ISO File: |====                | (22/100)

Importing ISO File: |====                | (23/100)

Importing ISO File: |====                | (24/100)

Importing ISO File: |=====               | (25/100)

Importing ISO File: |=====               | (26/100)

Importing ISO File: |=====               | (27/100)

Importing ISO File: |=====               | (28/100)

Importing ISO File: |=====               | (29/100)

Importing ISO File: |======              | (30/100)

Importing ISO File: |======              | (31/100)

Importing ISO File: |======              | (32/100)

Importing ISO File: |======              | (33/100)

Importing ISO File: |======              | (34/100)

Importing ISO File: |=======             | (35/100)

Importing ISO File: |=======             | (36/100)

Importing ISO File: |=======             | (37/100)

Importing ISO File: |=======             | (38/100)

Importing ISO File: |=======             | (39/100)

Importing ISO File: |========            | (40/100)

Importing ISO File: |========            | (41/100)

Importing ISO File: |========            | (42/100)

Importing ISO File: |========            | (43/100)

Importing ISO File: |========            | (44/100)

Importing ISO File: |=========           | (45/100)

Importing ISO File: |=========           | (46/100)

Importing ISO File: |=========           | (47/100)

Importing ISO File: |=========           | (48/100)

Importing ISO File: |=========           | (49/100)

Importing ISO File: |==========          | (50/100)

Importing ISO File: |==========          | (51/100)

Importing ISO File: |==========          | (52/100)

Importing ISO File: |==========          | (53/100)

Importing ISO File: |==========          | (54/100)

Importing ISO File: |===========         | (55/100)

Importing ISO File: |===========         | (56/100)

Importing ISO File: |===========         | (57/100)

Importing ISO File: |===========         | (58/100)

Importing ISO File: |===========         | (59/100)

Importing ISO File: |============        | (60/100)

Importing ISO File: |============        | (61/100)

Importing ISO File: |============        | (62/100)

Importing ISO File: |============        | (63/100)

Importing ISO File: |============        | (64/100)

Importing ISO File: |=============       | (65/100)

Importing ISO File: |=============       | (66/100)

Importing ISO File: |=============       | (67/100)

Importing ISO File: |=============       | (68/100)

Importing ISO File: |=============       | (69/100)

Importing ISO File: |==============      | (70/100)

Importing ISO File: |==============      | (71/100)

Importing ISO File: |==============      | (72/100)

Importing ISO File: |==============      | (73/100)

Importing ISO File: |==============      | (74/100)

Importing ISO File: |===============     | (75/100)

Importing ISO File: |===============     | (76/100)

Importing ISO File: |===============     | (77/100)

Importing ISO File: |===============     | (78/100)

Importing ISO File: |===============     | (79/100)

Importing ISO File: |================    | (80/100)

Importing ISO File: |================    | (81/100)

Importing ISO File: |================    | (82/100)

Importing ISO File: |================    | (83/100)

Importing ISO File: |================    | (84/100)

Importing ISO File: |=================   | (85/100)

Importing ISO File: |=================   | (86/100)

Importing ISO File: |=================   | (87/100)

Importing ISO File: |=================   | (88/100)

Importing ISO File: |=================   | (89/100)

Importing ISO File: |==================  | (90/100)

Importing ISO File: |==================  | (91/100)

Importing ISO File: |==================  | (92/100)

Importing ISO File: |==================  | (93/100)

Importing ISO File: |==================  | (94/100)

Importing ISO File: |=================== | (95/100)

Importing ISO File: |=================== | (96/100)

Importing ISO File: |=================== | (97/100)

Importing ISO File: |=================== | (98/100)

Importing ISO File: |=================== | (99/100)

Importing ISO File: |====================| (100/100)

                                                          

IsoMedia import The Wolverine_audio_PCM.mov - track ID 1 - Audio (SR 48000 - 8 channels)

Importing ISO File: |                    | (00/100)

Importing ISO File: |                    | (01/100)

Importing ISO File: |                    | (02/100)

Importing ISO File: |                    | (03/100)

Importing ISO File: |                    | (04/100)

Importing ISO File: |=                   | (05/100)

Importing ISO File: |=                   | (06/100)

Importing ISO File: |=                   | (07/100)

Importing ISO File: |=                   | (08/100)

Importing ISO File: |=                   | (09/100)

Importing ISO File: |==                  | (10/100)

Importing ISO File: |==                  | (11/100)

Importing ISO File: |==                  | (12/100)

Importing ISO File: |==                  | (13/100)

Importing ISO File: |==                  | (14/100)

Importing ISO File: |===                 | (15/100)

Importing ISO File: |===                 | (16/100)

Importing ISO File: |===                 | (17/100)

Importing ISO File: |===                 | (18/100)

Importing ISO File: |===                 | (19/100)

Importing ISO File: |====                | (20/100)

Importing ISO File: |====                | (21/100)

Importing ISO File: |====                | (22/100)

Importing ISO File: |====                | (23/100)

Importing ISO File: |====                | (24/100)

Importing ISO File: |=====               | (25/100)

Importing ISO File: |=====               | (26/100)

Importing ISO File: |=====               | (27/100)

Importing ISO File: |=====               | (28/100)

Importing ISO File: |=====               | (29/100)

Importing ISO File: |======              | (30/100)

Importing ISO File: |======              | (31/100)

Importing ISO File: |======              | (32/100)

Importing ISO File: |======              | (33/100)

Importing ISO File: |======              | (34/100)

Importing ISO File: |=======             | (35/100)

Importing ISO File: |=======             | (36/100)

Importing ISO File: |=======             | (37/100)

Importing ISO File: |=======             | (38/100)

Importing ISO File: |=======             | (39/100)

Importing ISO File: |========            | (40/100)

Importing ISO File: |========            | (41/100)

Importing ISO File: |========            | (42/100)

Importing ISO File: |========            | (43/100)

Importing ISO File: |========            | (44/100)

Importing ISO File: |=========           | (45/100)

Importing ISO File: |=========           | (46/100)

Importing ISO File: |=========           | (47/100)

Importing ISO File: |=========           | (48/100)

Importing ISO File: |=========           | (49/100)

Importing ISO File: |==========          | (50/100)

Importing ISO File: |==========          | (51/100)

Importing ISO File: |==========          | (52/100)

Importing ISO File: |==========          | (53/100)

Importing ISO File: |==========          | (54/100)

Importing ISO File: |===========         | (55/100)

Importing ISO File: |===========         | (56/100)

Importing ISO File: |===========         | (57/100)

Importing ISO File: |===========         | (58/100)

Importing ISO File: |===========         | (59/100)

Importing ISO File: |============        | (60/100)

Importing ISO File: |============        | (61/100)

Importing ISO File: |============        | (62/100)

Importing ISO File: |============        | (63/100)

Importing ISO File: |============        | (64/100)

Importing ISO File: |=============       | (65/100)

Importing ISO File: |=============       | (66/100)

Importing ISO File: |=============       | (67/100)

Importing ISO File: |=============       | (68/100)

Importing ISO File: |=============       | (69/100)

Importing ISO File: |==============      | (70/100)

Importing ISO File: |==============      | (71/100)

Importing ISO File: |==============      | (72/100)

Importing ISO File: |==============      | (73/100)

Importing ISO File: |==============      | (74/100)

Importing ISO File: |===============     | (75/100)

Importing ISO File: |===============     | (76/100)

Importing ISO File: |===============     | (77/100)

Importing ISO File: |===============     | (78/100)

Importing ISO File: |===============     | (79/100)

Importing ISO File: |================    | (80/100)

Importing ISO File: |================    | (81/100)

Importing ISO File: |================    | (82/100)

Importing ISO File: |================    | (83/100)

Importing ISO File: |================    | (84/100)

Importing ISO File: |=================   | (85/100)

Importing ISO File: |=================   | (86/100)

Importing ISO File: |=================   | (87/100)

Importing ISO File: |=================   | (88/100)

Importing ISO File: |=================   | (89/100)

Importing ISO File: |==================  | (90/100)

Importing ISO File: |==================  | (91/100)

Importing ISO File: |==================  | (92/100)

Importing ISO File: |==================  | (93/100)

Importing ISO File: |==================  | (94/100)

Importing ISO File: |=================== | (95/100)

Importing ISO File: |=================== | (96/100)

Importing ISO File: |=================== | (97/100)

Importing ISO File: |=================== | (98/100)

Importing ISO File: |=================== | (99/100)

Importing ISO File: |====================| (100/100)

                                                          

[iso file] Broken text box detected, skiping parsing.

IsoMedia import The Wolverine_audio_PCM.mov - track ID 2 - media type "text:text"

Importing ISO File: |                    | (02/100)

Importing ISO File: |=                   | (05/100)

Importing ISO File: |=                   | (08/100)

Importing ISO File: |==                  | (11/100)

Importing ISO File: |==                  | (13/100)

Importing ISO File: |===                 | (16/100)

Importing ISO File: |===                 | (19/100)

Importing ISO File: |====                | (22/100)

Importing ISO File: |=====               | (25/100)

Importing ISO File: |=====               | (27/100)

Importing ISO File: |======              | (30/100)

Importing ISO File: |======              | (33/100)

Importing ISO File: |=======             | (36/100)

Importing ISO File: |=======             | (38/100)

Importing ISO File: |========            | (41/100)

Importing ISO File: |========            | (44/100)

Importing ISO File: |=========           | (47/100)

Importing ISO File: |==========          | (50/100)

Importing ISO File: |==========          | (52/100)

Importing ISO File: |===========         | (55/100)

Importing ISO File: |===========         | (58/100)

Importing ISO File: |============        | (61/100)

Importing ISO File: |============        | (63/100)

Importing ISO File: |=============       | (66/100)

Importing ISO File: |=============       | (69/100)

Importing ISO File: |==============      | (72/100)

Importing ISO File: |===============     | (75/100)

Importing ISO File: |===============     | (77/100)

Importing ISO File: |================    | (80/100)

Importing ISO File: |================    | (83/100)

Importing ISO File: |=================   | (86/100)

Importing ISO File: |=================   | (88/100)

Importing ISO File: |==================  | (91/100)

Importing ISO File: |==================  | (94/100)

Importing ISO File: |=================== | (97/100)

Importing ISO File: |====================| (100/100)

                                                          

Unrecognized import option tx3g, ignoring

[Importer] Cannot load filter for input file "/Volumes/data02/3D/complete/The Wolverine/The Wolverine_subtitles.srt"

Failure while importing media: Requested URL is not valid or cannot be found

Error importing /Volumes/data02/3D/complete/The Wolverine/The Wolverine_subtitles.srt:hdlr=sbtl:group=2:name=English Subtitles:tx3g: Requested URL is not valid or cannot be found




Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/user/Development/oss/BD_to_AVP/bd_to_avp/main.py", line 778, in main
    process_each(input_args)
  File "/Users/user/Development/oss/BD_to_AVP/bd_to_avp/main.py", line 826, in process_each
    muxed_output_path = create_muxed_file(
                        ^^^^^^^^^^^^^^^^^^
  File "/Users/user/Development/oss/BD_to_AVP/bd_to_avp/main.py", line 909, in create_muxed_file
    mux_video_audio_subs(mv_hevc_path, audio_path, muxed_path, subtitle_path)
  File "/Users/user/Development/oss/BD_to_AVP/bd_to_avp/main.py", line 582, in mux_video_audio_subs
    run_command(command, "Mux video, audio, and subtitles.")
  File "/Users/user/Development/oss/BD_to_AVP/bd_to_avp/main.py", line 230, in run_command
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '[PosixPath('/Applications/GPAC.app/Contents/MacOS/MP4Box'), '-new', '-lang', 'eng', '-add', PosixPath('/Volumes/data02/3D/complete/The Wolverine/The Wolverine_MV-HEVC.mov'), '-add', PosixPath('/Volumes/data02/3D/complete/The Wolverine/The Wolverine_audio_PCM.mov'), '-add', '/Volumes/data02/3D/complete/The Wolverine/The Wolverine_subtitles.srt:hdlr=sbtl:group=2:name=English Subtitles:tx3g', PosixPath('/Volumes/data02/3D/complete/The Wolverine/The Wolverine_AVP.mov')]' returned non-zero exit status 1.

@cbusillo
Copy link
Owner

I wonder if there was an issue installing tesseract or something. Now that I am using MP4Box, maybe I can go back to using sub/idx instead of trying to OCR into SRT. I’ll try to get that done today.

@cbusillo
Copy link
Owner

Quick update and sorry this is such a pain everyone, testing just takes so long.

I tried reverting back to sub/idx instead of using OCR to generate srt files. QuickTime doesn't like them. I couldn't find any documented way to get QuickTime to work with that image based sub format.

I fixed the issue with srts. I didn't include tesseract in the deps and I was deleting the srt in the code. One of the changes left that stale piece of code. Neither of those issues were affecting me while developing since I already had the deps installed and I was using --keep-files so I could watch the process and debug each step. Oops. I am again testing the released version on a blank test machine. This takes a while because I need to erase and load macOS, then copy an ISO then run the entire bd-to-avp on a M1 Pro. Hopefully I will have a confirmed working version tomorrow.

Again sorry for all the back and forth on something so simple.

@ddevler
Copy link

ddevler commented May 28, 2024

vmware is now free for personal use. I usually make an empty VM for testing software. Then delete it after the test and copy over the empty image again. Copy is usually quicker than reloading the entire OS.

@cbusillo
Copy link
Owner

Ok, it's now working on a clean macOS install with default options. Feel free to give it a try everyone.

@cbusillo
Copy link
Owner

cbusillo commented Jun 1, 2024

If anyone has this specific issue again, feel free to reopen. Thank you for the help everyone.

@cbusillo cbusillo closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants