Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running FRIM to split MVC to stereo #9

Closed
mmalto opened this issue May 6, 2024 · 19 comments
Closed

Running FRIM to split MVC to stereo #9

mmalto opened this issue May 6, 2024 · 19 comments

Comments

@mmalto
Copy link

mmalto commented May 6, 2024

not sure on the expected duration so this may or may not be an actual issue. I have an m3 pro max and it's been "stuck" on "Running FRIM to split MVC to stereo." for over 12 hrs. I hate to cancel it if this is normal. any suggestions?

input: bd-to-avp --source Rogue\ One\ A\ Star\ Wars\ Story\ 3D.iso --output-root-folder .

Processing Rogue One A Star Wars Story 3D.iso
Running Get disc and MVC video properties /

Custom MakeMKV profile created at Rogue One A Star Wars Story/custom_profile.mmcp.xml
Running Rip disc to MKV file. /

Detecting crop parameters...
Getting subtitle tracks from Rogue One A Star Wars Story/Rogue One- A Star Wars Story_t07.mkv
Running ffmpeg to extract video, audio, and subtitles from MKV
Running Extract subtitle track from MKV /

Running FRIM to split MVC to stereo. \ <- stuck here for 12+ hrs

@cbusillo
Copy link
Owner

cbusillo commented May 6, 2024

I think it should take about an hour there. Maybe less on your machine. Do you have a different BD3D to test with? What does the created folder look like inside? The FRIM step should create a left and right log. What do you see in there?

@mmalto
Copy link
Author

mmalto commented May 6, 2024

I killed it:

Running FRIM to split MVC to stereo. |^C
Command interrupted.

Traceback (most recent call last):
File "/opt/homebrew/bin/bd-to-avp", line 8, in
sys.exit(main())
^^^^^^
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 732, in main
process_each(input_args)
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 771, in process_each
left_output_path, right_output_path = create_left_right_files(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 902, in create_left_right_files
split_mvc_to_stereo(
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 493, in split_mvc_to_stereo
run_command(frim_command, "FRIM to split MVC to stereo.")
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 211, in run_command
line = process.stdout.readline()
^^^^^^^^^^^^^^^^^^^^^^^^^
KeyboardInterrupt

@mmalto
Copy link
Author

mmalto commented May 6, 2024

@cbusillo
Copy link
Owner

cbusillo commented May 6, 2024

It looks like those finished. Are you running off the internal drive or an external?

@cbusillo
Copy link
Owner

cbusillo commented May 6, 2024

How long is that movie? The logs say it got to time index 02:13:57.24

@mmalto
Copy link
Author

mmalto commented May 6, 2024

running off internal drive. that would be the exact length of the movie...

image

@cbusillo
Copy link
Owner

cbusillo commented May 6, 2024

Is there any chance you are out of space?

@mmalto
Copy link
Author

mmalto commented May 6, 2024

nope. 1tb hd with 800b free.

@cbusillo
Copy link
Owner

cbusillo commented May 6, 2024

Do you have a different BD3D to test with? looking at the speeds of the decode in your logs, I would expect 2-3 hours max total.

@mmalto
Copy link
Author

mmalto commented May 6, 2024

blu31c33@mb-pro-max Downloads % bd-to-avp --source SMALLFOOT3D_2018.iso --output-root-folder .

Processing SMALLFOOT3D_2018.iso
Running Get disc and MVC video properties -

Custom MakeMKV profile created at Smallfoot 2018/custom_profile.mmcp.xml
Running Rip disc to MKV file. |

Detecting crop parameters...
Getting subtitle tracks from Smallfoot 2018/Smallfoot (2018)_t01.mkv
Running ffmpeg to extract video, audio, and subtitles from MKV
Running Extract subtitle track from MKV /

Running FRIM to split MVC to stereo. /

Running Combine stereo HEVC streams to MV-HEVC. |

Running Remux audio and video to final output. \

Removed existing directory: Smallfoot 2018

@mmalto
Copy link
Author

mmalto commented May 6, 2024

ill try it again..

@cbusillo
Copy link
Owner

cbusillo commented May 6, 2024

So success on movie two? Great. I haven't personally seen intermittent problems. It looks like your original movie was waiting for ffmpeg or FRIM to exit. Weird.

It seems like the second movie encoded pretty quick.

@mmalto
Copy link
Author

mmalto commented May 6, 2024

yeah, 2nd one worked but it didn't rip the 3d so it's just flat. it's also odd in that it locks up 41s into the movie. maybe that's a bug with moon player. I started movie 1 and it's hung again. definitely should have been done by now. are you able to rip the 3d stream or just the 2d?

@cbusillo
Copy link
Owner

cbusillo commented May 6, 2024

Sorry if it wasn't obvious, but moon player doesn't do MV-HEVC. The Files app will play it in 3d. I believe there are other apps too, but I don't remember off the time of my head. Cinema something maybe?

This will only rip the 3d stream. MV-HEVC should automatically downgrade to 2D for players that support HEVC.

Do you have the source BD for movie one?

@mmalto
Copy link
Author

mmalto commented May 7, 2024

went further this time:

Running FRIM to split MVC to stereo. \

Running Combine stereo HEVC streams to MV-HEVC. -

Running Remux audio and video to final output. -Error running command: Remux audio and video to final output.
[Importer] Cannot load filter for input file "Rogue One A Star Wars Story/Rogue One A Star Wars Story_MV-HEVC.mov"

Failure while importing media: Requested URL is not valid or cannot be found

Error importing Rogue One A Star Wars Story/Rogue One A Star Wars Story_MV-HEVC.mov: Requested URL is not valid or cannot be found

Traceback (most recent call last):
File "/opt/homebrew/bin/bd-to-avp", line 8, in
sys.exit(main())
^^^^^^
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 732, in main
process_each(input_args)
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 780, in process_each
muxed_output_path = create_muxed_file(
^^^^^^^^^^^^^^^^^^
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 862, in create_muxed_file
mux_video_audio_and_subtitles(
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 555, in mux_video_audio_and_subtitles
run_command(command, "Remux audio and video to final output.")
File "/Users/blu31c33/.bd_to_avp_venv/lib/python3.12/site-packages/bd_to_avp/main.py", line 220, in run_command
raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '[PosixPath('/opt/homebrew/bin/MP4Box'), '-add', PosixPath('Rogue One A Star Wars Story/Rogue One A Star Wars Story_MV-HEVC.mov'), '-add', PosixPath('Rogue One A Star Wars Story/Rogue One A Star Wars Story_audio_PCM.mov'), '-add', PosixPath('Rogue One A Star Wars Story/Rogue One A Star Wars Story_subtitle.idx'), PosixPath('Rogue One A Star Wars Story/Rogue One A Star Wars Story_AVP.mov')]' returned non-zero exit status 1.

@cbusillo
Copy link
Owner

cbusillo commented May 7, 2024

That is so weird. Especially how it got further this time. I haven't had any inconsistencies like that reported. You can continue where you left off with the --start-stage COMBINE_TO_MV_HEVC flag.

Does that file exist in the temp folder? Does it play? Did you have the original source disc to try? The script can read directly from a disk with -source disc:0 (I believe that is the syntax).

It is failing on the step where it puts the 3D video together with the audio and subs.

@mmalto
Copy link
Author

mmalto commented May 7, 2024

3rd time was the charm. you can mark this as resolved...

I changed the cmd line to this:

bd-to-avp --source r1.iso --output-root-folder ./r1

and it worked. I just forced a directory name instead of stating . for the output-root-folder. I also renamed the input .iso name to not have spaces in it. one of those things helped it move along.

thanks!

@mmalto
Copy link
Author

mmalto commented May 7, 2024

unfortunately, I no longer have a br disc drive so I couldn't test ripping direct. im mad b/c I forgot to strip the black bars, so I guess I'll be redoing again.

@cbusillo
Copy link
Owner

cbusillo commented May 7, 2024

Periods in the name SHOULD be stripped out. If you have time to test can you see if using . As the output root Caused the issue? If so I'll try to fix it. Since it creates a folder, I wouldn't expect that to be an issue... but you never know till you put it on the internet for others to try!

I'm glad you got it either way. Enjoy the video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants