Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.19 #10

Merged
merged 7 commits into from Jun 2, 2022
Merged

Update to 1.19 #10

merged 7 commits into from Jun 2, 2022

Conversation

caoimhebyrne
Copy link
Owner

This PR adds support for 1.19, this was a trivial change, however it also rewrites the OptionsScreen to no longer use SpruceUI, as it has held us back in the past when updating the mod, and is once again holding us back due to incompatibilities.

This PR will be merged when 1.19 is officially released by Mojang.

Note: the options screen doesn't work at the moment due to
text components being changed, SpruceUI does not support 1.19 yet.
SpruceUI wasn't really required for how simple our GUI is, and it's
just another thing holding us back when we want to update to newer
versions, as we have to wait for the maintainer to update when there
are incompatibilities. (like in 1.19)
@caoimhebyrne caoimhebyrne marked this pull request as draft May 29, 2022 10:56
@caoimhebyrne caoimhebyrne marked this pull request as ready for review June 2, 2022 15:39
@caoimhebyrne caoimhebyrne merged commit 2cf6ed5 into main Jun 2, 2022
@caoimhebyrne caoimhebyrne deleted the feat/1.19 branch June 2, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant