Depth head facelift #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisandeteng
requested review from
vict0rsch,
sashavor,
51N84D,
tianyu-z and
alexrey88
|
@vict0rsch @alexrey88 @51N84D @tianyu-z @sashavor can you please review this ? Thanks ! |
51N84D
approved these changes
Jul 23, 2020
tianyu-z
reviewed
Jul 23, 2020
| def get_normalized_depth_t(arr, domain): | ||
| def norm_tensor(t): | ||
| t = t - torch.min(t) | ||
| t /= torch.max(t) |
There was a problem hiding this comment.
Please correct me if I am wrong. I think min - max normalization should be: (t - min) / (max - min)
There was a problem hiding this comment.
Since I do the operation in 2 steps, then Min is 0 after t-torch.min(t)
| def get_normalized_depth_t(arr, domain): | ||
| def norm_tensor(t): | ||
| t = t - torch.min(t) | ||
| t /= torch.max(t) |
There was a problem hiding this comment.
Please correct me if I am wrong. I think min - max normalization should be: (t - min) / (max - min)
There was a problem hiding this comment.
see comment above
alexrey88
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the following changes are made to the depth head:
if you want to check what the inputs would look like, npy arrays of log depth predictions from Megadepth have been saved at
/network/tmp1/ccai/data/munit_dataset/trainA_megadepth_resized