Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Use sed to customise npm README's for packages #736

Closed
1 task
nimishbongale opened this issue Oct 19, 2020 · 4 comments · Fixed by #746
Closed
1 task

Use sed to customise npm README's for packages #736

nimishbongale opened this issue Oct 19, 2020 · 4 comments · Fixed by #746
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature Hacktoberfest Ideal for Hacktoberfest participation 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@nimishbongale
Copy link
Contributor

nimishbongale commented Oct 19, 2020

Problem

The README for npmjs is not customised for all the packages. They all copy the same README from the root.

Description

The installation guidelines needs a bit of changing. This can be done using the sed command to change the relevant lines of code after copying the README from the root.

Alternatives

Since the packages are separate on npmjs, they perhaps need their own slightly customised README's.

Implementation

  • I would be interested in implementing this feature.
@nimishbongale nimishbongale added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository Hacktoberfest Ideal for Hacktoberfest participation labels Oct 19, 2020
@neeraj-2
Copy link
Contributor

I would like to work on it.Can I?

@nimishbongale
Copy link
Contributor Author

nimishbongale commented Oct 20, 2020

Sure, go ahead @neeraj-2.

Just fyi, this is the part that needs changing:

To run the storybook for an individual package (say, fonts):

cd packages/fonts
npm install
npm run build
npm run storybook

@neeraj-2
Copy link
Contributor

Sure, go ahead @neeraj-2.

Just fyi, this is the part that needs changing:

To run the storybook for an individual package (say, fonts):

cd packages/fonts
npm install
npm run build
npm run storybook

Thanks, @nimishbongale , Can u elaborate that what changes we need to put here like do we need to add some other commands or set some command as optional.

@nimishbongale
Copy link
Contributor Author

When we publish a package to npm, the main README gets copied everywhere. This code is the one that helps with the publishing to npm:

https://github.com/creativecommons/vocabulary/blob/bb9a1306b176283a253f4a9b9b0d35ec1170ee05/packages/vocabulary/deploy.sh#L15

After the copying is done, within each individual packages, we would need to modify the README accordingly. Currently the README states how to run the fonts package only. But this can be programatically modified to include all, depending on the package.

After publishing to npm, the README gets shown here:

Vocabulary Planning automation moved this from To Triage to Done Nov 16, 2020
@possumbilities possumbilities removed this from Done in Vocabulary Planning Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature Hacktoberfest Ideal for Hacktoberfest participation 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Development

Successfully merging a pull request may close this issue.

2 participants