Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of clang's --config flag #1283

Open
isbadawi opened this issue May 7, 2023 · 0 comments
Open

Improve handling of clang's --config flag #1283

isbadawi opened this issue May 7, 2023 · 0 comments
Labels
help wanted The ccache maintainers need your help improvement Improvement that is not a bug fix or new feature

Comments

@isbadawi
Copy link

isbadawi commented May 7, 2023

Here is the documentation for this flag: https://clang.llvm.org/docs/UsersManual.html#configuration-files

Currently ccache handles it by hashing the contents of the config file, but this could lead to incorrect cache hits if the file happens to contain certain arguments like -fplugin= that would have been treated specially had they been specified directly on the command line instead of in the file. We could imagine treating the config file more like @-files instead, but there are some small differences to handle in the format.

(I guess the same is true for gcc's --specs flag which ccache handles the same way, but that format seems much more complex. I'm not super familiar with it. https://gcc.gnu.org/onlinedocs/gcc/Spec-Files.html)

As suggested in #850 (comment)

@isbadawi isbadawi added the improvement Improvement that is not a bug fix or new feature label May 7, 2023
@jrosdahl jrosdahl added the help wanted The ccache maintainers need your help label May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The ccache maintainers need your help improvement Improvement that is not a bug fix or new feature
Projects
None yet
Development

No branches or pull requests

2 participants