Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats file now uses create_empty_tmp_file, breaks the umask #45

Closed
afuruhed opened this issue Dec 9, 2014 · 4 comments
Closed

stats file now uses create_empty_tmp_file, breaks the umask #45

afuruhed opened this issue Dec 9, 2014 · 4 comments
Labels
bug Does not work as intended/documented

Comments

@afuruhed
Copy link

afuruhed commented Dec 9, 2014

The stats files need to have the same umask as other files, when sharing the cache among users.
It is now created as a tmp file and renamed, without updating the file permission.
I'm not sure what the most proper fix is so reporting as an issue here instead of / before suggesting a patch.

I guess this commit is to blame:
commit fc61ca9
Author: Joel Rosdahl joel@rosdahl.net
Date: Sat Nov 15 13:16:40 2014 +0100

Improve temporary file creation functions and usage
@jrosdahl
Copy link
Member

jrosdahl commented Dec 9, 2014

Same problems for .manifest files (and ccache.conf if "ccache -M" or "ccache -o" is used). fc61ca9 made the problem worse, but the first problematic commit is a07f46a.

@jrosdahl
Copy link
Member

jrosdahl commented Dec 9, 2014

See also ccache's official bug tracker: https://bugzilla.samba.org/show_bug.cgi?id=10978.

@afuruhed
Copy link
Author

afuruhed commented Dec 9, 2014

Ok, thanks.

@jrosdahl
Copy link
Member

Fixed in ccache v3.2.1.

@jrosdahl jrosdahl added the bug Does not work as intended/documented label Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Does not work as intended/documented
Projects
None yet
Development

No branches or pull requests

2 participants