Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer styles refactor #93

Open
mikemitchel opened this issue Feb 25, 2021 · 0 comments
Open

Viewer styles refactor #93

mikemitchel opened this issue Feb 25, 2021 · 0 comments

Comments

@mikemitchel
Copy link

The Viewer styles have complicated imports and seemingly circular dependencies that can often make it very difficult to figure out problems when a local style is being overwritten by a nested import. Need to break the styles down and move as much as possible local to the component that cares about that style, and make any top level or global styles easy to reason about and import as needed. For example, importing a single @variable requirement on even a simple .less file will often bring in extra styling as the first import starts grabbing it's dependencies that then grab their own dependencies inception style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant