Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules, async/await and other modern JS #234

Open
justinfagnani opened this issue Jun 30, 2018 · 2 comments
Open

Modules, async/await and other modern JS #234

justinfagnani opened this issue Jun 30, 2018 · 2 comments

Comments

@justinfagnani
Copy link

First, this is a great library! - it's the best organized and documented highlighter in JS I've found.

I've been in need of a pure JS modules highlighter, so I forked Rainbow and ported it to modules here: https://github.com/justinfagnani/rainbow

Along the way I did some other changes, like replacing callbacks with async/await and how the module script is created. Next up is getting the tests passing and a build setup for the worker.

Would you be interested in having these changes upstream? Most of them are breaking changes - even just getting modules wired up idiomatically means dropping the global Rainbow - so it'd have to be a 3.0.

Thanks for the great project!

@justinfagnani justinfagnani changed the title Modules, async/await and other Modules, async/await and other modern JS Jun 30, 2018
@abdonrd
Copy link

abdonrd commented Jul 9, 2018

It would be great to modernize the project! 👍

@abdonrd
Copy link

abdonrd commented Sep 13, 2018

@ccampbell Have you abandoned the project?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants