Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame dragging being blocked when it overlaps another frame #2

Closed
cccraig opened this issue Dec 12, 2018 · 1 comment
Closed

Fix frame dragging being blocked when it overlaps another frame #2

cccraig opened this issue Dec 12, 2018 · 1 comment

Comments

@cccraig
Copy link
Owner

cccraig commented Dec 12, 2018

If two faces are close together one face can be successfully tagged but the second face may be blocked because the first tag frame has a higher z-index than the image. This blocks the mouse over event and halts the dragging of the second frame. This can cause other issues, like releasing the mouse button but the frame drags with you.

Proposed fix is to dynamically change the z-index of previously created frames to hide them while the new frame is being drawn. Then revert the z-index after name has been entered.

@cccraig
Copy link
Owner Author

cccraig commented Aug 29, 2021

Fixed this with some CSS magic and the :not selector. This has resulted in the manifestation of some other behaviors that may / may not need fixing. As an example, suppose you take a group photo with the "Work Squad" and you tag all the people in it with their name. Later, for whatever reason, you decide to select the entire group and tag it as Work Squad. Doing this will work and retain the old tags but hovering over the tagged region would only show "work squad". This specific behavior should be fixed by displaying all tag names behind the selector area.

Secondly, you can't start tagging by clicking inside another tag. The overlap area is okay, if you click outside of another frame you can then drag into it and won't be blocked. I'm inclined to leave this behavior as is; if you've got another tag within a tag you've really not using the plugin as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant