Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HACKING.md suggests running a CentOS command on Ubuntu #76

Closed
greyspectrum opened this issue Jun 28, 2017 · 2 comments
Closed

HACKING.md suggests running a CentOS command on Ubuntu #76

greyspectrum opened this issue Jun 28, 2017 · 2 comments

Comments

@greyspectrum
Copy link
Contributor

On line 61 of HACKING.md in the "documentation" branch, under "Install required packages," the documentation suggests running:

$ sudo yum install python-virtualenv

However, this part of the documentation covers setting up a Ubuntu VM, so I believe it should be:

$ sudo apt install python-virtualenv

@kamfonik
Copy link
Contributor

@greyspectrum HACKING.md isn't actually in this repo yet, it's in a branch on my fork of it.

And Install Required Packages is actually a new heading, so we are back to assuming CentOS - although when I look at the formatted version it's not very obvious that that is the case, I will add some horizontal rules and fiddle with the heading levels to make that clearer.

@kamfonik
Copy link
Contributor

@greyspectrum I am going to close this issue for now but the feedback is appreciated - feel free to either send me notes on slack or whatever, or just keep notes for yourself and comment when there is a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants