Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Nix package #1102

Closed
berquist opened this issue Feb 5, 2022 · 8 comments · Fixed by #1367
Closed

Create Nix package #1102

berquist opened this issue Feb 5, 2022 · 8 comments · Fixed by #1367
Assignees
Milestone

Comments

@berquist
Copy link
Member

berquist commented Feb 5, 2022

https://www.breakds.org/post/build-python-package/

@berquist berquist added this to the v2.x milestone Feb 5, 2022
@shivupa
Copy link
Member

shivupa commented Feb 5, 2022

somewhat relevant https://onlinelibrary.wiley.com/doi/full/10.1002/qua.26872

@berquist
Copy link
Member Author

berquist commented Feb 5, 2022

somewhat relevant onlinelibrary.wiley.com/doi/full/10.1002/qua.26872

Thanks for the link, I was reading that (and https://github.com/markuskowa/NixOS-QChem) and thinking about how to get Q-Chem built this way, then realized packaging cclib is possible too.

I've marked this as 2.x not because it won't get done soon, but because Nix is not the easiest thing to get working.

I've made another packaging issue for Spack (#1103), but not Guix, mostly because I Don't have experience with it yet.

@berquist berquist self-assigned this Feb 23, 2022
@berquist
Copy link
Member Author

berquist commented Sep 7, 2023

It was added in Nix-QChem/NixOS-QChem#285 for version 1.7.2, but all the optional deps are missing and it looks like they're having problems with PyQt4 (Nix-QChem/NixOS-QChem#345) and that part of our code needs to be removed.

This issue can be closed once a PR on their repo bumps the version to 1.8.

@berquist
Copy link
Member Author

berquist commented Sep 8, 2023

PR: Nix-QChem/NixOS-QChem#346

I was hoping to put this in regular Nixpkgs but this is good enough.

@berquist berquist closed this as completed Sep 8, 2023
@berquist berquist modified the milestones: v2.x, v1.8.1 Sep 8, 2023
@sheepforce
Copy link
Contributor

sheepforce commented Sep 11, 2023

Thanks for the link, I was reading that (and https://github.com/markuskowa/NixOS-QChem) and thinking about how to get Q-Chem built this way, then realized packaging cclib is possible too.

Note that Q-Chem versions 5.1 to 5.4 are packed with Nix (https://github.com/Nix-QChem/NixOS-QChem/tree/master/pkgs/apps/q-chem).

It would also work perfectly fine to put nix files in the cclib repo itself to achieve a reproducible build and development environment. For example as we did in (pysisyphus).

@berquist berquist reopened this Jan 27, 2024
@berquist berquist modified the milestones: v1.8.1, v2.0 Jan 27, 2024
@berquist
Copy link
Member Author

Reopening because:

  • cclib: 1.7.2 -> 1.8 Nix-QChem/NixOS-QChem#346 didn't go through due to Qt4Progress (fixed in Remove Qt4Progress #1315) and API changes with iodata (we need to update the pin and make sure the same version is in NixOS-QChem)
  • I completely missed Phillip's comment. I had originally thought of putting a recipe in nixpkgs, then remembered NixOS-QChem.
    • Yes, I would rather add a flake here. I don't know how to have it depend on things in NixOS-QChem while also having things in NixOS-QChem depend on the cclib flake...or maybe that isn't an issue?
    • Completely unrelated to cclib, for Q-Chem I was referring to the developer version: the one compiled from source. Might revisit that someday.

@sheepforce
Copy link
Contributor

Sorry, now I've missed your comment 😅 If you wan't I can open a PR and wrap Nix around this Repo. It can depend on NixOS-QChem and NixOS-QChem can depend on this, that's not a problem.

@sheepforce sheepforce mentioned this issue Feb 22, 2024
@sheepforce
Copy link
Contributor

Completely unrelated to cclib, for Q-Chem I was referring to the developer version: the one compiled from source. Might revisit that someday.

If you wish, we could discuss this separately. Maybe just write me a mail to phillip.seeber@uni-jena.de. I could possibly help you out there.

@berquist berquist modified the milestones: v2.0, v2.0a Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants