Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't specify zero for mistakes #15

Closed
ccmars opened this issue Jul 10, 2023 · 0 comments · Fixed by #16
Closed

Can't specify zero for mistakes #15

ccmars opened this issue Jul 10, 2023 · 0 comments · Fixed by #16
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ccmars
Copy link
Owner

ccmars commented Jul 10, 2023

Setting the attribute data-typecadence-mistakes to 0 does not prevent mistakes from being present. This is likely due to seeing 0 as the property not being set. Check line 243 for where the mistakes property is set.
@ccmars ccmars added bug Something isn't working good first issue Good for newcomers labels Jul 10, 2023
@ccmars ccmars linked a pull request Jul 13, 2023 that will close this issue
Allow for mistakes to be set at zero #16
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for mistakes to be set at zero ccmars/typecadence
1 participant
@ccmars