Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing #22

Open
chadhietala opened this issue May 26, 2022 · 3 comments
Open

Contributing #22

chadhietala opened this issue May 26, 2022 · 3 comments

Comments

@chadhietala
Copy link
Contributor

Hello! I started using the api package to build out some documentation tools after running into issues with other tools in this space. Overall its been great. I do have a list of issues and potential areas for enhancement and was wondering if you're accepting contributions to the project.

Below are some of the issues that I recently found

@atanasster
Copy link
Contributor

Thanks @chadhietala for reporting the issues you encountered and would love to have contributions. It just so happened that the project is not very much promoted and so far have handled most issues myself, but definitely have nothing against contributions :)

Let me know if you need any help, or if you prefer me to handle any of your issues.

@chadhietala
Copy link
Contributor Author

chadhietala commented May 27, 2022

@atanasster I was looking at #19 and I believe the issue stems from this guard but I wasn't really sure how to evolve the code. If you have the time seeing the fix for that will give me a better idea on how to go about fixing some of the other issues.

@atanasster
Copy link
Contributor

@chadhietala you were absolutely on the right path for the fix, its just a bit more clunky.

I have fixed it now with #23 and it was published as @structured-types/api@3.46.11

Since the tests already included a test for getters/setters, I did not create a new test and just modified the existing one to expect the names of the getters/setters. For other issues it might be expected to create new tests and add them to the site examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants