Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V.reddit.com media has no sound #2567

Closed
jordanclock opened this issue Oct 16, 2017 · 8 comments
Closed

V.reddit.com media has no sound #2567

jordanclock opened this issue Oct 16, 2017 · 8 comments

Comments

@jordanclock
Copy link

Slide version: 5.6.5 alpha5.1
Android version: Pixel 8.0

All v.reddit.com media is mute. All other sounds in the app work as expected. Sound for v.reddit.com has not work even in preview builds.

@ccrama
Copy link
Collaborator

ccrama commented Oct 17, 2017

That will be really hard to fix, as sound is a separate file stream that must somehow be merged with the video file. It's meant to stream in a web view and the Android media view doesn't really support DASH streaming

@jordanclock
Copy link
Author

Then perhaps exclude v.reddit.com from gif view? Currently all the v.reddit.com links I see are labelled as gifs, which explains why the videos aren't opening in a browser for me.

@jordanclock
Copy link
Author

Also, I tried adding v.reddit.com to the custom domains list and they are still being handled by the gif viewer.

@ccrama
Copy link
Collaborator

ccrama commented Oct 17, 2017

The only other alternative is opening it on the web browser only which I feel is a worse compromise

@jordanclock
Copy link
Author

Could you possibly make the custom domains list supercede the internal viewer settings? At least then users could have the links open externally if we are okay with that trade off.

@ccrama
Copy link
Collaborator

ccrama commented Oct 22, 2017

It should (works for me), make sure the link is v.redd.it not v.reddit.it (some users were typing that incorrectly)

@jordanclock
Copy link
Author

I have added v.redd.it (mistakenly had v.reddit.com, derp) to the custom domains list. Unfortunately while the links open in Chrome, the tab goes away immediately. In Chrome Dev, Slide locks up but doesn't bring up a force close prompt.

@ccrama
Copy link
Collaborator

ccrama commented Jan 5, 2018

Fixed in next alpha!

@ccrama ccrama closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants