Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor links in Wikis do not work #2673

Closed
CometDog opened this issue Mar 3, 2018 · 3 comments
Closed

Anchor links in Wikis do not work #2673

CometDog opened this issue Mar 3, 2018 · 3 comments
Labels
Bug This is an issue with Slide. This is where something in the app isn't working as intended.

Comments

@CometDog
Copy link
Contributor

CometDog commented Mar 3, 2018 •
edited

A lot of time in Wikis, links are just references to anchor points on the page, e.g. "#wiki_keyboard_and_key_modifications". Clicking these links does nothing. Additionally, they're handled like regular links, meaning a long press opens the BottomSheet for opening and sharing, which it shouldn't because they're just references on the same page.

If the IDs of the HTML nodes are stripped before we write to the wiki, it's bad news bears. We'd have to keep the ID tags on the nodes so the Wiki links can utilize them.

Expected behavior: Selecting an anchor link on a wiki jumps me down to the correct part of the wiki page. Long Pressing an anchor link should not show the BottomSheet to share.
@CometDog CometDog changed the title Links in Wikis do not work Anchor links in Wikis do not work Mar 3, 2018
@CometDog
Copy link
Contributor Author

CometDog commented Mar 3, 2018

An additional issue brought up in this Reddit comment is that the links just reload the incorrect page. This would need reproduction (so would my issue obviously) since I can't reproduce it. That user is having other issues too so their problem could be unrelated.

@CometDog
Copy link
Contributor Author

CometDog commented Apr 8, 2018

Piwwow Thoughts:
Just swap out the Wiki native view implementation with Webviews to avoid dinged performance for having to build large, highly unique views

@CometDog
Copy link
Contributor Author

CometDog commented Jul 8, 2018 •
edited

Fixed here #2815

@Alexendoo Alexendoo added the Bug This is an issue with Slide. This is where something in the app isn't working as intended. label Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug This is an issue with Slide. This is where something in the app isn't working as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alexendoo @CometDog