Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to login with Javascript disabled in WebView #2974

Closed
guixxx opened this issue Feb 19, 2019 · 6 comments
Closed

Unable to login with Javascript disabled in WebView #2974

guixxx opened this issue Feb 19, 2019 · 6 comments
Labels
Bug This is an issue with Slide. This is where something in the app isn't working as intended. Complex This issue is complicated and may require a lot of work to fix. High Priority This issue is high on our todo list. It needs to be fixed as soon as possible.

Comments

@guixxx
Copy link

guixxx commented Feb 19, 2019

Slide version: 6.0.1-3
Android version: 7.1.2

I've been trying to login into my account since yesterday but with no luck so far. So I tried to authenticate using my desktop's browser, with javascript disabled, and it didn't work either (Reddit doesn't ask for my 2FA code). This is the auth URL Slide uses, but it only works with javascript:

https://www.reddit.com/login.compact?dest=https%3A%2F%2Fi.reddit.com%2Fapi%2Fv1%2Fauthorize.compact%3Fscope%3Didentity%2Bmodcontributors%2Bmodconfig%2Bmodothers%2Bmodwiki%2Bcreddits%2Blivemanage%2Baccount%2Bprivatemessages%2Bmodflair%2Bmodlog%2Breport%2Bmodposts%2Bmodwiki%2Bread%2Bvote%2Bedit%2Bsubmit%2Bsubscribe%2Bsave%2Bwikiread%2Bflair%2Bhistory%2Bmysubreddits%26response_type%3Dcode%26state%3D6tl3ecdgj0tjer5924pj6hn5h5%26redirect_uri%3Dhttp%253A%252F%252Fwww.ccrama.me%26client_id%3DKI2Nl9A_ouG9Qw%26duration%3Dpermanent

@Tensounder54 Tensounder54 added Bug This is an issue with Slide. This is where something in the app isn't working as intended. High Priority This issue is high on our todo list. It needs to be fixed as soon as possible. Complex This issue is complicated and may require a lot of work to fix. labels Feb 25, 2019
@Tensounder54
Copy link
Collaborator

Odd. Have you tried using this URL in a web browser?

@guixxx
Copy link
Author

guixxx commented Feb 26, 2019

Yes, I did. Here are my findings:

First off, my Reddit account has 2FA authentication.

  • After I click the "log in" button on the Reddit login page (using Slide + WebView), I'm redirected to the login page again (it was supposed to ask for my 2FA code).
  • Using this authentication URL on a desktop browser, with javascript enabled, works just fine, because Reddit (now?) uses XHR in the login page, hence why it doesn't work properly when javascript is disabled.
  • I am able to bypass this issue by appending :my_2fa_code in my password.

(Possible?) solution:

I'm not a Java programmer, nor did I test this, but wouldn't enabling Javascript in WebView fix this?

@DidierLmn
Copy link

Slide version: 6.0.1-3
Android version: 9

I'm having this same issue, 2FA is also enabled on my Reddit account.

As described above, through a web browser it's working, but through the webview it reloads the login page without asking for the 2FA code.

@MadFatVlad
Copy link

MadFatVlad commented Mar 25, 2019

I have found a solution described in Reddit Help! You should use 'password':'2fa code' instead of password

@ccrama
Copy link
Collaborator

ccrama commented Apr 6, 2019

2fa issue has been fixed for the next update, not sure there is a workaround for disabled JavaScript though because that is the only page for mobile auth through Reddit. I am planning on moving all login logic out of the app and letting the default browser handle this in a future update as well, which might change the constraints of this issue

@guixxx
Copy link
Author

guixxx commented May 1, 2021

I've tried to login a few days ago using Slide, and now Reddit asks for 2FA code.

Closing :)

@guixxx guixxx closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is an issue with Slide. This is where something in the app isn't working as intended. Complex This issue is complicated and may require a lot of work to fix. High Priority This issue is high on our todo list. It needs to be fixed as soon as possible.
Projects
None yet
Development

No branches or pull requests

5 participants