Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeClimate code analysis results #3033

Closed
Zhuinden opened this issue Jul 9, 2019 · 3 comments
Closed

CodeClimate code analysis results #3033

Zhuinden opened this issue Jul 9, 2019 · 3 comments
Labels
Complex This issue is complicated and may require a lot of work to fix. Enhancement This issue is requesting/proposing a change that will better a feature or aspect of Slide. Feedback This issue is giving feedback on Slide.

Comments

@Zhuinden
Copy link

Zhuinden commented Jul 9, 2019

Screenshot 2019-07-09 at 16 21 14
Screenshot 2019-07-09 at 16 21 41
Screenshot 2019-07-09 at 16 26 42
Screenshot 2019-07-09 at 16 27 07
Screenshot 2019-07-09 at 16 34 58

But code climate is free for all open-source repos, so you can try it yourself and see all issues rather than just the ones I took screenshots of.

I'm actually not affiliated with them, I just find the results interesting.

@Tensounder54
Copy link
Collaborator

What does it mean by:

Method doActions has 430 lines of code (exceeds 25 allowed). Consider refactoring.

@Zhuinden
Copy link
Author

Zhuinden commented Jul 9, 2019

It means that optimally, 1 method shouldn't be longer than 25 lines of code.

Although sometimes I violate that too, my repos seem to have some methods that are ~50 LOC (sometimes 80). Don't seem to have more than 100 in one method, though.

The idea is that you can use the Refactor -> Extract Method functionality that will extract selected code from inside a method into its own method.


Please note that I only screencapped some of the issues highlighted by the tool, not all of them.

@Tensounder54 Tensounder54 added Complex This issue is complicated and may require a lot of work to fix. Enhancement This issue is requesting/proposing a change that will better a feature or aspect of Slide. Feedback This issue is giving feedback on Slide. labels Aug 23, 2019
@Tensounder54
Copy link
Collaborator

We know about all this so I'm just going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complex This issue is complicated and may require a lot of work to fix. Enhancement This issue is requesting/proposing a change that will better a feature or aspect of Slide. Feedback This issue is giving feedback on Slide.
Projects
None yet
Development

No branches or pull requests

2 participants