New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsing comments - fold actual comment? #39
Comments
sorry, link here: https://imgur.com/a/PCrX1 |
+1 for this |
Agreed. |
Done, will add in next commit! |
Prelim code added in 85fb67c. Looks a bit strange, working on a smooth animation to make it more clean :) |
thank you! |
Awesome thanks! |
Ends up looking really bad and not working with the default recyclerview animations. I'll put this one on the books, but will mark as wontfix for now |
To be honest I'd rather no animation than current behavior, but... |
I'd agree with no animation, function has to trump form in some places and this is definitely one |
I'd agree with @The0x539 too. |
I'm not so fussed with the comments still being shown, but I would agree that animations slow down navigating through comments, maybe there could be a toggle in the settings somewhere to turn off animations? |
I don't understand, is this a "show top-level comments only" feature? |
No, this is about hiding the content of the top level comment too if you hide its children. |
I don't understand... |
So right now, if you longpress/tap a comment depending on setting, it hides all child comments. The idea, and the way most other access methods do it, the parent comment is, on top of that, collapsed to a single line of text in height. |
I still don't understand. So hide the top-level comments too? |
yes |
1 similar comment
yes |
Can this please be Revisited? |
I second this also. It's mostly important/an annoyance when a parent comment is quite large. When you tap and hold, you can see anything change and still have to scroll passed it to get to the next one. |
I personally really like it the way it currently is, if implemented it would be really nice if there was a toggle in the settings to still show the top comment. Similar to how it is with horizontal/vertical album view in the settings. |
Yes, please collapse parent comment too. There is a reason to collapsing the comment, because you're done with it. |
Added as a setting in c85e321 |
enhancement request:
Please make it that when you collapse a comment, it collapsed the actual comment along with that comment's children.
When collapsed, a comment can show just it's regular header, containing the OP, Vote count, time, and children count. tapping on this header will reopen the comment body and its children.
This will be very useful for Reddits with long top-level comments, like r/writing prompts.
link to a rough mockup:
TIA!!
The text was updated successfully, but these errors were encountered: