Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsing comments - fold actual comment? #39

Closed
SZE2 opened this issue Oct 11, 2015 · 24 comments
Closed

Collapsing comments - fold actual comment? #39

SZE2 opened this issue Oct 11, 2015 · 24 comments
Labels
Feature Request This issue is requesting a feature to be added to Slide.

Comments

@SZE2
Copy link

SZE2 commented Oct 11, 2015

enhancement request:

Please make it that when you collapse a comment, it collapsed the actual comment along with that comment's children.

When collapsed, a comment can show just it's regular header, containing the OP, Vote count, time, and children count. tapping on this header will reopen the comment body and its children.

This will be very useful for Reddits with long top-level comments, like r/writing prompts.

link to a rough mockup:

TIA!!

@SZE2
Copy link
Author

SZE2 commented Oct 11, 2015

sorry, link here: https://imgur.com/a/PCrX1

@l3d00m
Copy link
Contributor

l3d00m commented Oct 11, 2015

+1 for this

@Alexendoo Alexendoo added the Feature Request This issue is requesting a feature to be added to Slide. label Oct 11, 2015
@The0x539
Copy link
Collaborator

Agreed.

@ccrama
Copy link
Collaborator

ccrama commented Oct 12, 2015

Done, will add in next commit!

@ccrama ccrama modified the milestone: Alpha 4.0 Oct 12, 2015
@ccrama
Copy link
Collaborator

ccrama commented Oct 12, 2015

Prelim code added in 85fb67c. Looks a bit strange, working on a smooth animation to make it more clean :)

@SZE2
Copy link
Author

SZE2 commented Oct 12, 2015

thank you!

@l3d00m
Copy link
Contributor

l3d00m commented Oct 12, 2015

Awesome thanks!

@ccrama
Copy link
Collaborator

ccrama commented Oct 19, 2015

Ends up looking really bad and not working with the default recyclerview animations. I'll put this one on the books, but will mark as wontfix for now

@ccrama ccrama added the wontfix label Oct 19, 2015
@ccrama ccrama modified the milestones: Future, 4.1.0 (Alpha) Oct 19, 2015
@The0x539
Copy link
Collaborator

To be honest I'd rather no animation than current behavior, but...

@Alexendoo
Copy link
Member

I'd agree with no animation, function has to trump form in some places and this is definitely one

@l3d00m
Copy link
Contributor

l3d00m commented Oct 20, 2015

I'd agree with @The0x539 too.

@frederickfogerty
Copy link

I'm not so fussed with the comments still being shown, but I would agree that animations slow down navigating through comments, maybe there could be a toggle in the settings somewhere to turn off animations?

@ghost
Copy link

ghost commented Jan 12, 2016

I don't understand, is this a "show top-level comments only" feature?

@l3d00m
Copy link
Contributor

l3d00m commented Jan 12, 2016

No, this is about hiding the content of the top level comment too if you hide its children.

@ghost
Copy link

ghost commented Jan 12, 2016

I don't understand...

@The0x539
Copy link
Collaborator

So right now, if you longpress/tap a comment depending on setting, it hides all child comments. The idea, and the way most other access methods do it, the parent comment is, on top of that, collapsed to a single line of text in height.

@ghost
Copy link

ghost commented Jan 12, 2016

I still don't understand.

So hide the top-level comments too?

@l3d00m
Copy link
Contributor

l3d00m commented Jan 12, 2016

yes

1 similar comment
@ghost
Copy link

ghost commented Jan 12, 2016

yes

@SZE2
Copy link
Author

SZE2 commented Jan 22, 2016

Can this please be Revisited?
I see that the Milestone of 4.1.0 has passed...
Don't mind me if this sounds pushy... thanks!

@Alexendoo Alexendoo removed this from the Future milestone Feb 8, 2016
@2fst4u
Copy link

2fst4u commented Feb 13, 2016

I second this also. It's mostly important/an annoyance when a parent comment is quite large. When you tap and hold, you can see anything change and still have to scroll passed it to get to the next one.

@tejassharma96
Copy link

I personally really like it the way it currently is, if implemented it would be really nice if there was a toggle in the settings to still show the top comment. Similar to how it is with horizontal/vertical album view in the settings.

@raazman
Copy link

raazman commented Feb 16, 2016

Yes, please collapse parent comment too. There is a reason to collapsing the comment, because you're done with it.

@l3d00m
Copy link
Contributor

l3d00m commented Feb 25, 2016

Added as a setting in c85e321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request This issue is requesting a feature to be added to Slide.
Projects
None yet
Development

No branches or pull requests

9 participants