Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating screen twice returns to the top of the list #748

Closed
trentusus opened this issue Jan 9, 2016 · 21 comments
Closed

Rotating screen twice returns to the top of the list #748

trentusus opened this issue Jan 9, 2016 · 21 comments
Labels
Bug This is an issue with Slide. This is where something in the app isn't working as intended.
Milestone

Comments

@trentusus
Copy link

When scrolling through a list of posts, starting in portrait mode. Rotating to landscape maintains the position in the list. Rotating back to portrait returns you to the top of the list. Should the position be maintained?

@Alexendoo Alexendoo added the Bug This is an issue with Slide. This is where something in the app isn't working as intended. label Jan 9, 2016
@l3d00m
Copy link
Contributor

l3d00m commented Jan 12, 2016

Which Slide version are you using? I cannot reproduce it on the alpha

@l3d00m l3d00m added the Needs Reproduction This issue needs to be reproduced by another person. label Jan 12, 2016
@trentusus
Copy link
Author

4.5
Only happens on posts. Not in comments.
On 13 Jan 2016 7:08 AM, "Thomas Lu" notifications@github.com wrote:

Which Slide version are you using? I cannot reproduce it on the alpha


Reply to this email directly or view it on GitHub
#748 (comment).

@hary585
Copy link

hary585 commented Jan 13, 2016

I tried it, no issues for me.

@l3d00m
Copy link
Contributor

l3d00m commented Jan 13, 2016

Same for me and some other guys on the IRC.

@ccrama
Copy link
Collaborator

ccrama commented Jan 13, 2016

No issue for me either :(

@trentusus
Copy link
Author

How strange... I just reinstalled and it still happens when I rotate twice
on the front page list. Must be just me :/
On 14 Jan 2016 8:01 AM, "ccrama" notifications@github.com wrote:

No issue for me either :(


Reply to this email directly or view it on GitHub
#748 (comment).

@ccrama
Copy link
Collaborator

ccrama commented Jan 13, 2016

A lot of that is handled by your OS, so might just be a device specific issue. What phone do you have?

@trentusus
Copy link
Author

HTC One M8
Running Android 6
On 14 Jan 2016 9:31 AM, "ccrama" notifications@github.com wrote:

A lot of that is handled by your OS, so might just be a device specific
issue. What phone do you have?


Reply to this email directly or view it on GitHub
#748 (comment).

@Korpip
Copy link

Korpip commented Jan 13, 2016

I was able to reproduce on both my Nexus 7 2013(flo) and Moto X Play (lux) both running M.
In this video you will also see an image distortion bug in the image thumbnails after rotation.
The distorted images only happens on my Moto X Play which leads me to think that this bug is not one with Slide but more of a device thing that Slide might have to work around.
www.vid.me/eFFQ

@willheineman
Copy link

Reproduced on my Nexus 6 running 6.0.1. Slide 4.5.1

@amweiss
Copy link

amweiss commented Feb 13, 2016

Reproduced on my Nexus 5x running 6.0.1 with Slide 4.5.1

@l3d00m
Copy link
Contributor

l3d00m commented Feb 13, 2016

Looks like a marshmallow issue.

@l3d00m l3d00m removed the Needs Reproduction This issue needs to be reproduced by another person. label Feb 13, 2016
@Alexendoo Alexendoo added this to the Release milestone Feb 13, 2016
@ccrama
Copy link
Collaborator

ccrama commented Feb 13, 2016

Ooh, if it's just marshmallow, this is a bug with Google's RecyclerView and not Slide. Interesting! I'm waiting for marshmallow on my priv atm :(

@Plastix
Copy link
Contributor

Plastix commented Feb 13, 2016

I cannot replicate this issue running on my Nexus 5 running 6.0.1 with Slide 4.5.1

@l3d00m l3d00m removed this from the Release milestone Feb 13, 2016
@amweiss
Copy link

amweiss commented Feb 13, 2016

Probably doesn't help, but this doesn't happen in sync.

@ccrama
Copy link
Collaborator

ccrama commented Feb 13, 2016

@amweiss No it doesn't help

@amweiss
Copy link

amweiss commented Feb 13, 2016

Well this should help:
It doesn't happen in slide while viewing comments, only posts with card mode disabled.

@Alexendoo Alexendoo added this to the Release milestone Feb 14, 2016
@amweiss
Copy link

amweiss commented Feb 18, 2016

As of 4.6.0-83-e62230c it happens in card mode for posts now as well.

@amweiss
Copy link

amweiss commented Feb 18, 2016

Now seems fixed in 4.6.0-89-4a4143c.

@trentusus
Copy link
Author

I also confirm this is fixed on my device. Thanks!
On 19 Feb 2016 3:49 AM, "Adam Weiss" notifications@github.com wrote:

Now seems fixed in 4.6.0-89-4a4143c.


Reply to this email directly or view it on GitHub
#748 (comment).

@ccrama
Copy link
Collaborator

ccrama commented Feb 24, 2016

Woo! Glad it's working now

@ccrama ccrama closed this as completed Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is an issue with Slide. This is where something in the app isn't working as intended.
Projects
None yet
Development

No branches or pull requests

9 participants