[WIP] Use objects for subscriptions #1439
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using objects for subscriptions gives us multiple opportunities in the feature. It's easier to make subreddits local only (you don't have to remove them every time then), multireddits could be displayed in the mainactivity as well and it makes a lot of complicated code obsolete.
It's not near to being finished yet & it's completely untested.
KNOWN BUGS:
TODO:
Port the old subreddit storage method (via Stringbuilder, seperated by commas) in sharedPrefs to the new one. Currently you have to clear cache to make it working.