Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use objects for subscriptions #1439

Closed
wants to merge 3 commits into from
Closed

[WIP] Use objects for subscriptions #1439

wants to merge 3 commits into from

Conversation

l3d00m
Copy link
Contributor

@l3d00m l3d00m commented Apr 15, 2016

Using objects for subscriptions gives us multiple opportunities in the feature. It's easier to make subreddits local only (you don't have to remove them every time then), multireddits could be displayed in the mainactivity as well and it makes a lot of complicated code obsolete.
It's not near to being finished yet & it's completely untested.

KNOWN BUGS:

  • It doesn't display the correct subreddits on first start
  • It does ask if you would like to sub to /r/slide each time on login, also I'm already subbed
  • doesn't display frontpage and all
  • probably a lot of bugs in ReorderSubreddits.java (it's not tested there in any way)

TODO:

  • Port the old subreddit storage method (via Stringbuilder, seperated by commas) in sharedPrefs to the new one. Currently you have to clear cache to make it working.
  • Use FileOutputStream or sqllite instead of SharedPrefs to avoid problems (Reference)
  • Add sorting of subscription in the object as well
  • Add a better handling for collections
  • Add multireddits to MainActivity
  • Testing, testing, testing. This changes a lot of underlying code and has therefore a high chance of breaking something
  • Add a syncSubscriptionsOverwrite in MainActivity - NotificationAsync. This will allow an automatic subreddit sync. New subreddits will be then displayed at next startup. It wasn't possible before because it would have overwritten if the user deleted a sub. This is fixed now because that is stored in SubscriptionType.HIDDEN
  • Write tests to confirm that everything is working like it should

@l3d00m l3d00m self-assigned this Apr 15, 2016
@l3d00m l3d00m assigned Nxt3 and unassigned l3d00m Apr 15, 2016
@Nxt3 Nxt3 assigned l3d00m and unassigned Nxt3 May 27, 2016
@l3d00m l3d00m removed their assignment Aug 29, 2016
@l3d00m
Copy link
Contributor Author

l3d00m commented Aug 29, 2016

I'll close it as it is too far behind master to merge it (if it would be ready). I won't have any time to work on it in the near future too.

@l3d00m l3d00m closed this Aug 29, 2016
@Alexendoo Alexendoo deleted the feat/sub_object branch November 22, 2016 14:13
@Alexendoo Alexendoo restored the feat/sub_object branch November 22, 2016 14:13
@Alexendoo Alexendoo deleted the feat/sub_object branch November 22, 2016 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants