Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting shows that you'll be exporting a '.wav' no matter the chosen file format. #25

Open
ericheep opened this issue Sep 29, 2015 · 2 comments

Comments

@ericheep
Copy link

The file is still exported as the chosen format, but the "Export to:" box leads you to believe that '.wav' extension will be attached to the file.

export-bug

@leanne63
Copy link
Contributor

The user is currently allowed to choose up to 3 different save formats via the WAV, M4A, and Ogg Vorbis checkboxes (and potentially MP3, though that's hidden by default).

To address the issue of changing from a '.wav' default extension, a couple of decisions need to be made:

  1. Is it okay to show no extension?
  2. If not, what should be shown if the user selects multiple formats?

Discussion:

  • Leaving the extension out: if the 'Export to:' text doesn't show any extension, the user may attempt to type their own - which may or may not be correct. How would we determine the file name the user wants vs a file name that includes a typed-in extension, perhaps by mistake? For example, the user wants 'myFileName.wav'. They end up with 'myFileName.wav.wav' or 'myFileName.wav.m4a'?

  • The extension and output format currently default to '.wav' and 'WAV'. We could keep this, but then change the extension as the user selects something other than '.wav' - as long as they only make one selection; ie, if they click 'M4A', then '.wav' gets changed to '.m4A'. However, if multiple formats are selected, what extension should display? '.*' perhaps?

@spencersalazar
Copy link
Member

Thanks for breaking it down like that. Displaying an extension depending on the type and displaying .* in the case of multiple file types seems like the simplest, clearest solution, so lets go with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants