Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small mp4 videos scale up #365

Open
LuisBurdallo opened this issue Oct 5, 2022 · 10 comments
Open

Small mp4 videos scale up #365

LuisBurdallo opened this issue Oct 5, 2022 · 10 comments

Comments

@LuisBurdallo
Copy link

It seems trying to watch some mp4 I have it scales the resolution of the video if they are too small. Anything we can do to avoid this and playback at the original resolution?

@LuisBurdallo LuisBurdallo changed the title Video preview scaled up Small mp4 videos scale up Oct 5, 2022
@ccseer
Copy link
Owner

ccseer commented Oct 5, 2022

How small is your mp4?
There is minimal size for the preview window, so currently the video will be scaled to the minimal size if its smaller.

@LuisBurdallo
Copy link
Author

256x256

@ccseer
Copy link
Owner

ccseer commented Oct 5, 2022

can you send me a sample

@LuisBurdallo
Copy link
Author

@ccseer
Copy link
Owner

ccseer commented Oct 5, 2022

got it. thanks

@ccseer
Copy link
Owner

ccseer commented Oct 6, 2022

If we allow video to scale up, then Seer needs a stateful button to switch video size between default size and scaled, just like Image module. I'm not sure about this.

@LuisBurdallo
Copy link
Author

LuisBurdallo commented Oct 6, 2022

Ok I see it an image can be scale up to it's original resolution when using control then you can pan by click and dragging. That's great. Can't this be applied to a video? Where you can control mouse wheel to do the same? I realize maybe this is what you mentioned on your previous reply? What would be the negative part of adding such feature?

@ccseer
Copy link
Owner

ccseer commented Oct 6, 2022

Have you ever seen a video with scrollbar?
Because I haven't.

@ccseer
Copy link
Owner

ccseer commented Oct 6, 2022

If the video size is large, we show its original size, then we need to show two scrollbars. That's too weird

@LuisBurdallo
Copy link
Author

LuisBurdallo commented Oct 6, 2022

I didn't mean to add a scrollbar. I mean that the video could behave to change it's scaling to be expanded as you have it now if the video is too small and then it's original resolution. No need for a scroll bar. Just the scrolling capability using shift you already have implemented. Just so everything feels consistent and you don't have to add any button. There would only be 2 states "original and expanded" states. This I guess would only happens for small videos as I guess Seer shows you a 720p video at 720p, right? I mean if the video is large enough it doesn't really scale up. Anyway this was just a small and not very important request. If this is something that could take too long/hard to implement then it won't be worth it for what you get in return. I just happened to have a tool that makes tiny videos and they looked pixelated using Seer that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants