Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliced ImageSets use too much memory #437

Closed
phyy-nx opened this issue Sep 25, 2021 · 0 comments · Fixed by #438
Closed

Sliced ImageSets use too much memory #437

phyy-nx opened this issue Sep 25, 2021 · 0 comments · Fixed by #438

Comments

@phyy-nx
Copy link

phyy-nx commented Sep 25, 2021

At the moment, when creating an ImageSet that represents a slice of a multi-image datafile, the Reader object that is created to hold the arrays of dxtbx models is of size max(single_file_indices) instead of size len(single_file_indices). This leads to huge arrays with only one item for stills.

For example, if I have an hdf5 file with 10 images, and I an equivalent imageset for it, and I slice it like this:

subset = imageset[5:6]

Then single_file_indices will be the array [5], but the ImageSetData object will have a list of models with 6 items, the first 5 of which will be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant