Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCC (Bitcoin Cash) symbol in Binance exchange should be BCH #402

Closed
guopengliang opened this issue Oct 26, 2017 · 14 comments
Closed

BCC (Bitcoin Cash) symbol in Binance exchange should be BCH #402

guopengliang opened this issue Oct 26, 2017 · 14 comments
Assignees

Comments

@guopengliang
Copy link

In fact, most Chinese exchanges use BCC for Bitcoin Cash. It's better if we correct this in CCXT to make it less confusing.

@kroitor
Copy link
Member

kroitor commented Oct 26, 2017

Hi, thx for opening this issue! I will correct that right away, very soon.

References:

https://github.com/ccxt-dev/ccxt/wiki/Manual#naming-consistency
#83
#129

@kroitor kroitor self-assigned this Oct 26, 2017
@kroitor
Copy link
Member

kroitor commented Oct 26, 2017

This issue has been fixed in 1.9.267+. Thx again for your feedback!

@eniuz
Copy link

eniuz commented Feb 14, 2018

issue came back

@kroitor
Copy link
Member

kroitor commented Feb 14, 2018

@eniuz can you elaborate, please?

@abagh0703
Copy link

abagh0703 commented Feb 21, 2018

@kroitor I think he means that when you search on the Binance exchange, "BCH" shows no results but "BCC" shows a result representing bitcoin cash.

@kroitor
Copy link
Member

kroitor commented Feb 21, 2018

@abagh0703 in that case it's explained here: https://github.com/ccxt/ccxt/wiki/Manual#symbols-and-market-ids

@cookiemonster846
Copy link

Can this be fixed? All large exchanges use the BCH symbol instead of BCC.

@kroitor
Copy link
Member

kroitor commented Apr 29, 2018

@cookiemonster846 this has been fixed long ago... Just use the most recent version of CCXT and make sure to read this carefully: https://github.com/ccxt/ccxt/wiki/Manual#symbols-and-market-ids

@jjaone
Copy link

jjaone commented Nov 13, 2018

No, it has not been fixed. The Binance official Android app doesn't recognize BCH, but only shows BCC in every trading related view and tab.

@kroitor
Copy link
Member

kroitor commented Nov 14, 2018

@jjaone the mapping has been fixed in CCXT. As for Binance official apps and their symbols – you should probably forward this to Binance if you don't agree to their mapping. In CCXT BCH has the BCH symbol, so the mapping was fixed in CCXT long ago as described in the Manual:

@jjaone
Copy link

jjaone commented Nov 14, 2018

@kroitor The topic of this issue is 'bitcoin cash' symbol in Binance exchange should be BCH".. thus I commented that in Binance exhange viewed either via their website or official Android app that coin's symbol is BCC everywhere, and not BCH as it should.

Thus, it has not been fixed (in Binance).

@kroitor
Copy link
Member

kroitor commented Nov 14, 2018

Thus, it has not been fixed (in Binance).

Yes, in Binance's applications it has not been fixed, but if you look into other exchanges as well, they have all sorts of inconsistencies with symbols, as described by those links above. And we have fixtures and remapping for those cases to bring them to consistency within CCXT. So we don't see it as an issue with the CCXT lib (the mapping of BCC vs BCH has been fixed in CCXT upon submission of this issue). Therefore, if some exchange shows a weird symbol in some of their software applications – it's beyond our library, I'm afraid, and in that case we can't help, unfortunately, as we're not responsible for those exchanges' apps. Hope this clarifies my previous answer.

@kroitor
Copy link
Member

kroitor commented Nov 14, 2018

The conflict of BCC vs BCH has been fixed in CCXT implementation of Binance here: https://github.com/ccxt/ccxt/blob/master/js/binance.js#L260.

So, "this issue opened in CCXT has been fixed" === "it is fixed in CCXT". As for their website or mobile apps not showing symbols properly – the question about BCC should be forwarded to Binance support, rather than CCXT.

@eniuz
Copy link

eniuz commented Nov 14, 2018

Sorry for late answer. I'm a developer I got lost in my editor for a while. it's obviously not an issue for someone who has time to think for a moment. is a bad UX for anybody who doesn't live in China if that matters to anybody. We're forced to live in global world with global economy. I don't remember why have I posted this here. So sorry if this is wrong place. In the same time I can see that many people know about the issue :) All the Best!

academe-01 pushed a commit to academe-01/ccxt that referenced this issue Oct 2, 2022
Ftx :: fix format_scientific_notation_ftx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants