Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OKCoinUSD's fetchTrades function returns integer id #434

Closed
hrtshu opened this issue Nov 1, 2017 · 1 comment
Closed

OKCoinUSD's fetchTrades function returns integer id #434

hrtshu opened this issue Nov 1, 2017 · 1 comment
Assignees
@kroitor

Comments

@hrtshu
Copy link

hrtshu commented Nov 1, 2017

I found that fetchTrades function of OKCoinUSD returns integer id.
According to the documentation, this function must return string id.

Python:

ccxt/python/ccxt/okcoinusd.py

Line 191 in cf67518

'id': trade['tid'],

JavaScript:

ccxt/js/okcoinusd.js

Line 200 in cf67518

'id': trade['tid'],

PHP:

ccxt/php/okcoinusd.php

Line 197 in cf67518

'id' => $trade['tid'],

@kroitor kroitor self-assigned this Nov 1, 2017
@kroitor kroitor closed this as completed in 3539ab3 Nov 1, 2017
@kroitor
Copy link
Member

kroitor commented Nov 1, 2017

This issue was fixed in 1.9.305. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kroitor kroitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kroitor @hrtshu