Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hole filling in TextureMesh #143

Open
saedrna opened this issue Nov 16, 2016 · 8 comments
Open

Hole filling in TextureMesh #143

saedrna opened this issue Nov 16, 2016 · 8 comments

Comments

@saedrna
Copy link

saedrna commented Nov 16, 2016

I have played with both TextureMesh and the original algorithm mvs-texturing and found out that OpenMVS handles the outliers better.

But I think the hole filling part for invisible triangles, which is added after the paper, is still a good idea to be considered. I have looked into the code, and found that the it searched for neighbor triangles of the invisible ones, and then did something similar to image inpainting and generate a new texture patch for the invisible triangles.

Is this feature able to be considered in OpenMVS?

Thanks,

Han

@cdcseacave
Copy link
Owner

Thanks for your suggestion and constructive contribution. I didn't look at MVE project since more than a year, so I do not know about this hole filling addition. Could you point me to it? Also, please feel free to implement it yourself in OpenMVS, the project is open to everybody.

@saedrna
Copy link
Author

saedrna commented Nov 16, 2016

Please find the function fill_hole in this file as below.

bool fill_hole(std::vector<std::size_t> const & hole, UniGraph const & graph,
    mve::TriangleMesh::ConstPtr mesh, mve::MeshInfo const & mesh_info,
    std::vector<std::vector<VertexProjectionInfo> > * vertex_projection_infos,
    std::vector<TexturePatch::Ptr> * texture_patches)

I'm now stuck in a lunar project, and when I finish my job, I hope I'll get some time to reimplement this in OpenMVS.

@cdcseacave
Copy link
Owner

Great, thx. Is this lunar project also related to photogrammetry? Could you share more details about it?

@saedrna
Copy link
Author

saedrna commented Nov 17, 2016

Yes, about photogrammetry, but just a job for food.

@cdcseacave
Copy link
Owner

I tell you something: add the hole filling functionality to OpenMVS in the next 12h and we can speak about a serious job in photogrammetry for you, not only for food, but for fun too.

@tftangming
Copy link

@saedrna hello! I plan to achieve the hole-filling in the openMVS, can you give me some help about it and whether there are some impossible problem?
Thanks!

@manalihiremath30
Copy link

Please find the function fill_hole in this file as below.

bool fill_hole(std::vector<std::size_t> const & hole, UniGraph const & graph,
    mve::TriangleMesh::ConstPtr mesh, mve::MeshInfo const & mesh_info,
    std::vector<std::vector<VertexProjectionInfo> > * vertex_projection_infos,
    std::vector<TexturePatch::Ptr> * texture_patches)

I'm now stuck in a lunar project, and when I finish my job, I hope I'll get some time to reimplement this in OpenMVS.

Please find the function fill_hole in this file as below.

bool fill_hole(std::vector<std::size_t> const & hole, UniGraph const & graph,
    mve::TriangleMesh::ConstPtr mesh, mve::MeshInfo const & mesh_info,
    std::vector<std::vector<VertexProjectionInfo> > * vertex_projection_infos,
    std::vector<TexturePatch::Ptr> * texture_patches)

Hey can u please explain what exactly they have done in this code like step wise. As i am wroking on it and i am not much familiar with c++ code. It would be veryyy helpful to me

@guyuezuntinggithub
Copy link

I am stuck in this problem too, I use the original algorithm nmoehrle/mvs-texturing#59 and get some big texture holes and the fill_hole fuction just fill manifold hole, but there many nonmanifold texture holes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants