[TRIAGE] New failures following the fee computations

[cdecker]

The changes in fee estimation seems to cause quite a few new failures. Here's the list of failing tests, some of the may just be flakes, and I guess most of them are caused by crazy fee-estimation on regtest.

1. test_direct_payment-eclair_lightning.log
2. test_direct_payment-lightning_eclair.log
3. test_direct_payment-lnd_eclair.log
4. test_direct_payment-lnd_lightning.log
5. test_forwarded_payment-eclair_lightning_eclair.log
6. test_forwarded_payment-eclair_lightning_lightning.log
7. test_forwarded_payment-eclair_lnd_eclair.log
8. test_forwarded_payment-eclair_lnd_lightning.log
9. test_forwarded_payment-lightning_eclair_lightning.log
10. test_forwarded_payment-lightning_lightning_eclair.log
11. test_forwarded_payment-lightning_lnd_eclair.log
12. test_forwarded_payment-lnd_eclair_eclair.log
13. test_forwarded_payment-lnd_eclair_lightning.log
14. test_forwarded_payment-lnd_eclair_lnd.log
15. test_forwarded_payment-lnd_lightning_eclair.log
16. test_forwarded_payment-lnd_lightning_lightning.log
17. test_forwarded_payment-lnd_lightning_lnd.log
18. test_forwarded_payment-lnd_lnd_eclair.log
19. test_forwarded_payment-lnd_lnd_lightning.log
20. test_gossip-lightning_eclair.log
21. test_open_channel-lnd_eclair.log
22. test_open_channel-lnd_lightning.log
23. test_reconnect-lnd_eclair.log
24. test_reconnect-lnd_lightning.log

Pretty sure at least nr. 20 is a flake. Will rerun to confirm :-)

[cdecker]

Ping @Roasbeef, @rustyrussell, @pm47, @sstone ^^

[Roasbeef]

On the lnd -> c-lightning funding, looks like they rejected our funding request due to insufficient fees:

EBUG:lnd(16331):2017-11-29 17:25:34.567 [DBG] PEER: Received Error(chan_id=d67e295044505c21108475d67babe5734992e85236a5b52eb859e5d002b83962, err=[102 101 101 114 97 116 101 95 112 101 114 95 107 119 32 54 48 48 48 32 98 101 108 111 119 32 109 105 110 105 109 117 109 32 49 48 48 48 48 0]) from 127.0.0.1:16332
DEBUG:proc:lightning_openingd(2795): STATUS_FAIL_PEER_BAD: feerate_per_kw 6000 below minimum 10000
D

[Roasbeef]

Seems if I just double our hard coded fee rate (no estimation) then most of those will go away?

[Roasbeef]

Same thing with funding to eclair:

DEBUG:lnd(16331):2017-11-29 17:23:47.647 [DBG] PEER: Received Error(chan_id=bc2357ff6dd8b7497ba3e886d2a9772c2d3d4fa5ac31455830344edee538e249, err=[108 111 99 97 108 47 114 101 109 111 116 101 32 102 101 101 114 97 116 101 115 32 97 114 101 32 116 111 111 32 100 105 102 102 101 114 101 110 116 58 32 114 101 109 111 116 101 70 101 101 114 97 116 101 80 101 114 75 119 61 54 48 48 48 32 108 111 99 97 108 70 101 101 114 97 116 101 80 101 114 75 119 61 53 51 55 54 48]) from 127.0.0.1:16332
DEBUG:lnd(16331):2017-11-29 17:23:47.647 [TRC] PEER: readMessage from 127.0.0.1:16332: (*lnwire.Error)(0xc420138380)({
DEBUG:lnd(16331): ChanID: (lnwire.ChannelID) (len=32 cap=32) bc2357ff6dd8b7497ba3e886d2a9772c2d3d4fa5ac31455830344edee538e249,
DEBUG:lnd(16331): Data: (lnwire.ErrorData) (len=88 cap=88) {
DEBUG:lnd(16331):  00000000  6c 6f 63 61 6c 2f 72 65  6d 6f 74 65 20 66 65 65  |local/remote fee|
DEBUG:lnd(16331):  00000010  72 61 74 65 73 20 61 72  65 20 74 6f 6f 20 64 69  |rates are too di|
DEBUG:lnd(16331):  00000020  66 66 65 72 65 6e 74 3a  20 72 65 6d 6f 74 65 46  |fferent: remoteF|
DEBUG:lnd(16331):  00000030  65 65 72 61 74 65 50 65  72 4b 77 3d 36 30 30 30  |eeratePerKw=6000|
DEBUG:lnd(16331):  00000040  20 6c 6f 63 61 6c 46 65  65 72 61 74 65 50 65 72  | localFeeratePer|
DEBUG:lnd(16331):  00000050  4b 77 3d 35 33 37 36 30                           |Kw=53760|
DEBUG:lnd(16331): }
DEBUG:lnd(16331):})
DEBUG:lnd(16331):
DEBUG:lnd(16331):2017-11-29 17:23:47.647 [ERR] FNDG: Received funding error from 0216a00f15d22a565e9064e16a3a6827fbd36099ee28a5d86bbdee4081b6be4b9d: unknown error
DEBUG:lnd(16331):2017-11-29 17:23:47.647 [INF] FNDG: Cancelling funding reservation for node_key=0216a00f15d22a565e9064e16a3a6827fbd36099ee28a5d86bbdee4081b6be4b9d, chan_id=bc2357ff6dd8b7497ba3e886d2a9772c2d3d4fa5ac31455830344edee538e249
DEBUG:lnd(16331):2017-11-29 17:23:47.647 [ERR] RPCS: unable to open channel to identityPub() nor peerID(1): rpc error: code = Code(208) desc = unknown error

[cdecker]

Seems if I just double our hard coded fee rate (no estimation) then most of those will go away?

Yep, I tried adjusting c-lightning to lnd which added failures with eclair :-)

We should be able to meet somewhere in the middle, but I don't know what the value should be ;-)