-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors look washed out #34
Comments
The video file looks good from a metadata persecptive, but obviously something is going on to cause the issue. First lets just go from the other direction to make sure we don't overlook the basics, are you playing it a player that handles HDR correctly? For example, here is a crop from VLC of a 10-bit movie, that you can see looks right when playing, but their snapshots are still 8-bit (top left). So similarly if you have a player that can't color map correctly that can happen. (Can even happen in VLC itself) File I converted with FastFlix to download to test and make sure is showing reds correctly: Using GlassBlowing video from Dolby Vision demo files. You can try the conversion with your copy of FastFlix / FFmpeg to make sure it works as well. (I just did first 10 seconds or so at ultrafast preset with no audio for this test). |
OK, so here are screen shots from the original MKV outputed from MakeMKV in VLC and the file from FastFix 2.2.0. So I don't think it is a player issue at this point. (I also followed the link to make sure my settings in VLC were right. I can confirm it looks the same if I view it on my LG OLED TV streamed from my Roku. I'll post the MediaInfo for the original and encoded next! (This is the one with all of the NL errors) |
Source Info: General Video |
This is the info on the FastFix 2.2.0 encoded file. I just did 1 minute General Video |
Yeah, FastFlix is screwing up somehow, missing all hdr info that time. Can you paste the command it's generating? For any tests run, feel free to just do a few seconds at ultrafast. I apprecaite you working with me on this issue and sorry it's causing such problems, don't want to waste any extra time! |
Oh please, no need to apologize - you are doing ME (and others a huge favor) by making this program! Thank YOU! Here's the command (I didn't change the times for the 1 min but doesn't matter): "{ffmpeg}" -y -i "F:/Days of Thunder_t00.mkv" -to 6437.9 -map 0:0 -c:v libx265 -crf 20 -preset slow -map 0:2 -metadata:s:1 title="Surround 5.1" -metadata:s:1 handler="Surround 5.1" -c:1 copy -map 0:3 -c:2 copy -disposition:s:2 0 -metadata:s:2 language=eng -map_chapters 0 "{output}" (If I helps I can drop a little of the stream to you privately somewhere or share with you via dropbox) |
In case it helps, this is the DEBUG string right before it generates the command in the CMD window: DEBUG - 2020-07-18 18:10:58,191 - Settings gathered: {'crop': None, 'scale': None, 'source': 'F:/Days of Thunder_t00.mkv', 'start_time': 0.0, 'duration': 6437.9, 'video_track': 0, 'rotate': None, 'v_flip': False, 'h_flip': False, 'streams': {'video': [{'index': 0, 'codec_name': 'hevc', 'codec_long_name': 'H.265 / HEVC (High Efficiency Video Coding)', 'profile': 'Main 10', 'codec_type': 'video', 'codec_time_base': '1001/24000', 'codec_tag_string': '[0][0][0][0]', 'codec_tag': '0x0000', 'width': 3840, 'height': 2160, 'coded_width': 3840, 'coded_height': 2160, 'closed_captions': 0, 'has_b_frames': 3, 'sample_aspect_ratio': '1:1', 'display_aspect_ratio': '16:9', 'pix_fmt': 'yuv420p10le', 'level': 153, 'color_range': 'tv', 'color_space': 'bt2020nc', 'color_transfer': 'smpte2084', 'color_primaries': 'bt2020', 'chroma_location': 'topleft', 'refs': 1, 'r_frame_rate': '24000/1001', 'avg_frame_rate': '24000/1001', 'time_base': '1/1000', 'start_pts': 0, 'start_time': '0.000000', 'disposition': {'default': 0, 'dub': 0, 'original': 0, 'comment': 0, 'lyrics': 0, 'karaoke': 0, 'forced': 0, 'hearing_impaired': 0, 'visual_impaired': 0, 'clean_effects': 0, 'attached_pic': 0, 'timed_thumbnails': 0}, 'tags': {'language': 'eng', 'BPS-eng': '62879059', 'DURATION-eng': '01:47:17.097333333', 'NUMBER_OF_FRAMES-eng': '154336', 'NUMBER_OF_BYTES-eng': '50594826039', 'SOURCE_ID-eng': '001011', '_STATISTICS_WRITING_APP-eng': 'MakeMKV v1.15.1 win(x64-release)', '_STATISTICS_WRITING_DATE_UTC-eng': '2020-07-13 01:10:12', '_STATISTICS_TAGS-eng': 'BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES SOURCE_ID'}}], 'audio': [{'index': 1, 'codec_name': 'truehd', 'codec_long_name': 'TrueHD', 'codec_type': 'audio', 'codec_time_base': '1/48000', 'codec_tag_string': '[0][0][0][0]', 'codec_tag': '0x0000', 'sample_fmt': 's32', 'sample_rate': '48000', 'channels': 6, 'channel_layout': '5.1(side)', 'bits_per_sample': 0, 'r_frame_rate': '0/0', 'avg_frame_rate': '0/0', 'time_base': '1/1000', 'start_pts': 0, 'start_time': '0.000000', 'bits_per_raw_sample': '24', 'disposition': {'default': 1, 'dub': 0, 'original': 0, 'comment': 0, 'lyrics': 0, 'karaoke': 0, 'forced': 0, 'hearing_impaired': 0, 'visual_impaired': 0, 'clean_effects': 0, 'attached_pic': 0, 'timed_thumbnails': 0}, 'tags': {'language': 'eng', 'title': 'Surround 5.1', 'BPS-eng': '3333585', 'DURATION-eng': '01:47:17.097500000', 'NUMBER_OF_FRAMES-eng': '7724517', 'NUMBER_OF_BYTES-eng': '2682326580', 'SOURCE_ID-eng': '001100', '_STATISTICS_WRITING_APP-eng': 'MakeMKV v1.15.1 win(x64-release)', '_STATISTICS_WRITING_DATE_UTC-eng': '2020-07-13 01:10:12', '_STATISTICS_TAGS-eng': 'BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES SOURCE_ID'}}, {'index': 2, 'codec_name': 'ac3', 'codec_long_name': 'ATSC A/52A (AC-3)', 'codec_type': 'audio', 'codec_time_base': '1/48000', 'codec_tag_string': '[0][0][0][0]', 'codec_tag': '0x0000', 'sample_fmt': 'fltp', 'sample_rate': '48000', 'channels': 6, 'channel_layout': '5.1(side)', 'bits_per_sample': 0, 'dmix_mode': '-1', 'ltrt_cmixlev': '-1.000000', 'ltrt_surmixlev': '-1.000000', 'loro_cmixlev': '-1.000000', 'loro_surmixlev': '-1.000000', 'r_frame_rate': '0/0', 'avg_frame_rate': '0/0', 'time_base': '1/1000', 'start_pts': 0, 'start_time': '0.000000', 'bit_rate': '640000', 'disposition': {'default': 0, 'dub': 0, 'original': 0, 'comment': 0, 'lyrics': 0, 'karaoke': 0, 'forced': 0, 'hearing_impaired': 0, 'visual_impaired': 0, 'clean_effects': 0, 'attached_pic': 0, 'timed_thumbnails': 0}, 'tags': {'language': 'eng', 'title': 'Surround 5.1', 'BPS-eng': '640000', 'DURATION-eng': '01:47:17.120000000', 'NUMBER_OF_FRAMES-eng': '201160', 'NUMBER_OF_BYTES-eng': '514969600', 'SOURCE_ID-eng': '001100', '_STATISTICS_WRITING_APP-eng': 'MakeMKV v1.15.1 win(x64-release)', '_STATISTICS_WRITING_DATE_UTC-eng': '2020-07-13 01:10:12', '_STATISTICS_TAGS-eng': 'BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES SOURCE_ID'}}], 'subtitle': [{'index': 3, 'codec_name': 'hdmv_pgs_subtitle', 'codec_long_name': 'HDMV Presentation Graphic Stream subtitles', 'codec_type': 'subtitle', 'codec_time_base': '0/1', 'codec_tag_string': '[0][0][0][0]', 'codec_tag': '0x0000', 'r_frame_rate': '0/0', 'avg_frame_rate': '0/0', 'time_base': '1/1000', 'start_pts': 0, 'start_time': '0.000000', 'duration_ts': 6437097, 'duration': '6437.097000', 'disposition': {'default': 0, 'dub': 0, 'original': 0, 'comment': 0, 'lyrics': 0, 'karaoke': 0, 'forced': 0, 'hearing_impaired': 0, 'visual_impaired': 0, 'clean_effects': 0, 'attached_pic': 0, 'timed_thumbnails': 0}, 'tags': {'language': 'eng', 'BPS-eng': '40176', 'DURATION-eng': '01:40:46.978437500', 'NUMBER_OF_FRAMES-eng': '2442', 'NUMBER_OF_BYTES-eng': '30368203', 'SOURCE_ID-eng': '0012A0', '_STATISTICS_WRITING_APP-eng': 'MakeMKV v1.15.1 win(x64-release)', '_STATISTICS_WRITING_DATE_UTC-eng': '2020-07-13 01:10:12', '_STATISTICS_TAGS-eng': 'BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES SOURCE_ID'}}], 'attachment': [], 'data': []}, 'format_info': {'filename': 'F:/Days of Thunder_t00.mkv', 'nb_streams': 4, 'nb_programs': 0, 'format_name': 'matroska,webm', 'format_long_name': 'Matroska / WebM', 'start_time': '0.000000', 'duration': '6437.097000', 'size': '53833067012', 'bit_rate': '66903533', 'probe_score': 100, 'tags': {'title': 'Days of Thunder', 'encoder': 'libmakemkv v1.15.1 (1.3.5/1.4.7) win(x64-release)', 'creation_time': '2020-07-13T01:10:12.000000Z'}}, 'work_dir': WindowsPath('C:/Users/Chris Schwarz/AppData/Roaming/FastFlix'), 'side_data': None, 'disable_hdr': False, 'preset': 'slow', 'intra_encoding': False, 'max_mux': 'default', 'extra': '', 'crf': 20, 'audio_tracks': [{'index': 2, 'outdex': 1, 'conversion': {'codec': 'none', 'bitrate': '768k'}, 'codec': 'ac3', 'downmix': 0, 'title': 'Surround 5.1'}], 'subtitle_tracks': [{'index': 3, 'outdex': 2, 'disposition': 0, 'language': 'eng'}]} |
For some reason it must be still blorking grabbing the HDR details, because it seems as if it can't find them at all. I wonder if ffprobe isn't giving back proper json or something and may just have to parse another way. This build has some extra debug info for trying to figure this out. It also has a "bug" that it allows all audio to passthrough. https://ci.appveyor.com/project/cdgriffith/fastflix/build/artifacts There should be an error message as soon as you open the source that starts with "COULD NOT PARSE FFPROBE HDR METADATA" please copy the next two lines of STDOUT and STDERR. |
Here's what it gives: ERROR - 2020-07-18 19:08:57,455 - COULD NOT PARSE FFPROBE HDR METADATA, PLEASE OPEN ISSUE WITH THESE DETAILS: STDOUT: STDERR: 'C:\Users\Chris' is not recognized as an internal or external command, operable program or batch file. Thanks! |
bangs head against table repeatedly Good news, I'm an idiot and forgot the quote the path to ffprobe, so because there was spaces in the path to it, it croaked. https://ci.appveyor.com/project/cdgriffith/fastflix/build/artifacts |
You nailed it! It works - no washed out colors now!! Thank you! I also tried the ac3 conversion from DTS and it works with my roku so this is great!
I will say the only weird thing is the mediainfo reports really weird info for the video. The frame rate is messed up and the bitrate isn't right. This file is only 57.6MB so that is 7.68Mbits/second. Probably a FFMPEG issue, but I thought I'd mention it. Here's what I mean:
```
GeneralUnique ID : 181275038171992097963923575827981492467 (0x88604D6B4D21E5D155B2A56CDDC560F3)
Complete name : F:\RAMBO II_t00-flix-1595133626.mkv
Format : Matroska
Format version : Version 4
File size : 57.7 MiB
Duration : 1 min 0 s
Overall bit rate : 8 063 kb/s
Movie name : RAMBO II
Writing application : Lavf58.48.100
Writing library : Lavf58.48.100
ErrorDetectionType : Per level 1
VideoID : 1
ID in the original source medium : 4113 (0x1011)
Format : HEVC
Format/Info : High Efficiency Video Coding
Format profile : Main 10@L5@Main
HDR format : SMPTE ST 2086, HDR10 compatible
Codec ID : V_MPEGH/ISO/HEVC
Duration : 1 min 0 s
Bit rate : 63.3 Mb/s
Width : 3 840 pixels
Height : 2 160 pixels
Display aspect ratio : 16:9
Frame rate mode : Variable
Frame rate : 2 299.675 FPS
Original frame rate : 24.000 FPS
```
|
I've seen weirdness for mediainfos bitrates when cutting down videos into smaller duration, but never seen that wrong of a frame rate being listed. Does it play fine or act weird? |
Plays ok but just making sure! Got Rambo ok going here. The 1 min I made looks great!
…Sent from my iPhone
On Jul 18, 2020, at 10:25 PM, Chris Griffith ***@***.***> wrote:
I've seen weirdness for mediainfos bitrates when cutting down videos into smaller duration, but never seen that wrong of a frame rate being listed. Does it play fine or act weird?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Fixed in 2.3.0 https://github.com/cdgriffith/FastFlix/releases/tag/2.3.0 |
Original issue raised in #30 by @schlotkins
Converted video details looked good, but the colors still look washed out.
Example from handbrake:
Example from ffmpeg output:
![87595359-42265a00-c6a3-11ea-8792-c68767050c2e](https://user-images.githubusercontent.com/3275435/87863076-e0712480-c91c-11ea-8f1d-575cebd1664b.png)
The text was updated successfully, but these errors were encountered: