-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imghdr matches in PureMagic? #68
Comments
Did |
Looking at the The current magic in PureMagic would not pick this up as it currently has a longer variant specific match, adding a short match like above is fine, but it can lead to low confidence scores and potential clashes if another file uses the same header. The best approach for good match scores and a definitive solid match is to use the longest header and multi-match possible. I'll likely run up a PR using the same conventions as I did for PCX, this issue is more about a thought about naming conventions and potential better presentation of the results. Also, as an aside, SGI would make a great example of a rule-based detection as the header is quite complicated with about 6 unique fixed fingerprints. |
I meant all the tests in that file for all the format, not just |
Looking at the source again, a quick run-down:
X Bitmap looks to not be present, SGI we know needs some love, the other formats are supported to at least the same degree the |
I'll close this as my PR #75 was merged but it did not close this. |
I've re-titled this as it got a bit off-track from the original purpose of the issue.
@cclauss wanted to know if PureMagic could provide a 1:1 replacement of imghdr, to avoid crosstalk I've moved the original content to #69
The text was updated successfully, but these errors were encountered: