New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDI-650 Introduce asynchronous event notification options #337
Conversation
@cdi-spec/eg please review... |
After quite a lengthy conversation we had on this topic yesterday with Martin and Tomas, I give this idea +1.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 as well. We'll probably be asked to make CDI more "reactive" in the next release(s), providing a way to add features in that direction without bloating the spec is a good approach.
IMO We need a specific doc for the NotificationOptions in the spec and an perhaps a way to access it on the observer side (thru EventMetadata?)
I find the current wording (attached to
I'm not so sure and I would prefer keep things simple in 2.0 - we can extend |
Ok, let's keep more advanced feature for 2.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the javadoc, "The container is permitted to define other non-portable notification options.", will this encourage containers to define more and more non-portable behaviours? I think we should leave it out, as I suggest we spec the options in CDI 2.1. |
We must leave some space for experiments so that impls can test options that can be later standardized. |
I understand that. Do we need to doc this 'freedom'? |
I think so, BTW we already use similar wording in the spec -> CTRL + F |
ok. No further comments. LGTM |
https://issues.jboss.org/browse/CDI-650